Sorry, something went wrong.
|
@serhiy-storchaka If you don't mind, would you take a look at this refactor - see if you have any concerns? |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 FreeBSD 3.x has failed when building commit e9791ba. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/1223/builds/222 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_concurrent_futures/test_shutdown.py", line 250, in test_cancel_futures_wait_false
self.assertEqual(out.strip(), b"apple")
AssertionError: b'' != b'apple'
|
Sorry, something went wrong.
While reviewing #96161, I too had difficulty fully understanding the complexities of _strip_extra function.
This PR refactors that function to use a class with methods separating the concerns (parsing, splitting, filtering, modeling) and using a higher-level abstraction to model the concept.