|
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks @erlend-aasland ; this is a substantial improvement to the previous docs.
Perhaps its worth fixing the other couple remaining similar docs defects also introduced in PR #101607 , namely in the descriptions of the newly documented functions PyException_GetArgs and PyException_SetArgs (that could use a similar (if much simpler) treatment as here), and the deprecation notices added to PyErr_Fetch, PyErr_Restore and PyErr_NormalizeException not being added to, and particularly duplicating, the .. deprecated directive.
Sorry, something went wrong.
|
Thanks @erlend-aasland ; this is a substantial improvement to the previous docs. Thanks, and thanks for the review! Perhaps its worth fixing the other couple remaining similar docs defects also introduced in PR #101607 , namely in the descriptions of the newly documented functions PyException_GetArgs and PyException_SetArgs (that could use a similar (if much simpler) treatment as here), and the deprecation notices added to PyErr_Fetch, PyErr_Restore and PyErr_NormalizeException not being added to, and particularly duplicating, the .. deprecated directive. Definitely; perhaps as a follow-up PR? |
Sorry, something went wrong.
|
Definitely; perhaps as a follow-up PR? Yeah certainly could be; up to you, of course |
Sorry, something went wrong.
There was a problem hiding this comment.
A couple followup suggestions
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM from me; thanks @erlend-aasland !
Sorry, something went wrong.
|
Thanks for the review, CAM; highly appreciated. I'll wait for @iritkatriel's or @markshannon's approval before landing. |
Sorry, something went wrong.
|
Thanks for the reviews, Irit and CAM; highly appreciated. I'll create a follow-up PR Any Time Soon™. |
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.