← 返回首页
gh-101819: Adapt _io types to heap types, batch 1 by erlend-aasland · Pull Request #101949 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-101819: Adapt _io types to heap types, batch 1#101949

Merged
miss-islington merged 20 commits into
python:mainfrom
erlend-aasland:isolate-io/1-heap-types
Feb 20, 2023
Merged

gh-101819: Adapt _io types to heap types, batch 1#101949
miss-islington merged 20 commits into
python:mainfrom
erlend-aasland:isolate-io/1-heap-types

Conversation

erlend-aasland commented Feb 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adapt StringIO, TextIOWrapper, FileIO, Buffered*, and BytesIO types.

Automerge-Triggered-By: GH:erlend-aasland

bedevere-bot mentioned this pull request Feb 16, 2023
Closed
erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023

bedevere-bot commented Feb 16, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit eeb5c48 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023
erlend-aasland commented Feb 16, 2023
View reviewed changes
Comment thread Modules/_io/_iomodule.c Outdated Show resolved Hide resolved
erlend-aasland marked this pull request as ready for review February 16, 2023 13:08
erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023

bedevere-bot commented Feb 16, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit c1926a6 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023
erlend-aasland marked this pull request as draft February 16, 2023 13:46
erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023

bedevere-bot commented Feb 16, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 65c0086 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

2 hidden items Load more…
bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 16, 2023

erlend-aasland commented Feb 17, 2023

Copy link
Copy Markdown
Contributor Author

(Pulled in main to see if Eric's test_imp PR may fix the bots)

kumaraditya303 reviewed Feb 19, 2023
View reviewed changes
Comment thread Modules/_io/textio.c Show resolved Hide resolved
kumaraditya303 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 19, 2023

bedevere-bot commented Feb 19, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 86a6dbc 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 19, 2023
erlend-aasland marked this pull request as ready for review February 19, 2023 19:46

miss-islington commented Feb 19, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

erlend-aasland commented Feb 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Let's wait until the macOS CI is healthy [on main] before landing.

miss-islington commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

miss-islington commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.

miss-islington merged commit c00faf7 into python:main Feb 20, 2023
erlend-aasland deleted the isolate-io/1-heap-types branch February 20, 2023 13:51

erlend-aasland commented Feb 20, 2023

Copy link
Copy Markdown
Contributor Author

We might have broken CI: https://buildbot.python.org/all/#/builders/729/builds/3820

jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 20, 2023
pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949 …
13882e0
) Adapt StringIO, TextIOWrapper, FileIO, Buffered*, and BytesIO types. Automerge-Triggered-By: GH:erlend-aasland
jaraco mentioned this pull request Feb 20, 2023
Closed
carljm added a commit to carljm/cpython that referenced this pull request Feb 20, 2023
Merge branch 'main' into inlinecomp2 …
9f0fc5b
* main: (60 commits) pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078) pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012) pythongh-101566: Sync with zipp 3.14. (pythonGH-102018) pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161) pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074) pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912) pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949) pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070) pythongh-97786: Fix compiler warnings in pytime.c (python#101826) pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962) Misc improvements to the float tutorial (pythonGH-102052) pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046) pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854) Add missing 'is' to `cmath.log()` docstring (python#102049) pythongh-100210: Correct the comment link for unescaping HTML (python#100212) pythongh-97930: Also include subdirectory in makefile. (python#102030) pythongh-99735: Use required=True in argparse subparsers example (python#100927) Fix incorrectly documented attribute in csv docs (python#101250) pythonGH-84783: Make the slice object hashable (pythonGH-101264) ...
carljm added a commit to carljm/cpython that referenced this pull request Feb 22, 2023
Merge branch 'main' into inlinecomp …
544b30c
* main: (225 commits) pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078) pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012) pythongh-101566: Sync with zipp 3.14. (pythonGH-102018) pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161) pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074) pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912) pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949) pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070) pythongh-97786: Fix compiler warnings in pytime.c (python#101826) pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962) Misc improvements to the float tutorial (pythonGH-102052) pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046) pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854) Add missing 'is' to `cmath.log()` docstring (python#102049) pythongh-100210: Correct the comment link for unescaping HTML (python#100212) pythongh-97930: Also include subdirectory in makefile. (python#102030) pythongh-99735: Use required=True in argparse subparsers example (python#100927) Fix incorrectly documented attribute in csv docs (python#101250) pythonGH-84783: Make the slice object hashable (pythonGH-101264) ...
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949 …
34e4ff2
) Adapt StringIO, TextIOWrapper, FileIO, Buffered*, and BytesIO types. Automerge-Triggered-By: GH:erlend-aasland
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949 …
575d8d0
) Adapt StringIO, TextIOWrapper, FileIO, Buffered*, and BytesIO types. Automerge-Triggered-By: GH:erlend-aasland
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.