← 返回首页
gh-101283: Fix use of unbound variable by zooba · Pull Request #101712 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-101283: Fix use of unbound variable#101712

Merged
zooba merged 1 commit into
python:mainfrom
zooba:gh-101283
Feb 8, 2023
Merged

gh-101283: Fix use of unbound variable#101712
zooba merged 1 commit into
python:mainfrom
zooba:gh-101283

Conversation

Copy link
Copy Markdown
Member

zooba commented Feb 8, 2023 •
edited by bedevere-bot
Loading

zooba added the skip news label Feb 8, 2023
zooba requested a review from gpshead as a code owner February 8, 2023 22:33
bedevere-bot mentioned this pull request Feb 8, 2023
Closed
Copy link
Copy Markdown
Member Author

zooba commented Feb 8, 2023

No need for backports, as I've made the change in the original backport PRs.

zooba mentioned this pull request Feb 8, 2023
Merged
eryksun reviewed Feb 8, 2023
View reviewed changes
Comment thread Lib/subprocess.py
Comment on lines +1498 to 1500
comspec = executable

args = '{} /c "{}"'.format (comspec, args)
Copy link
Copy Markdown
Contributor

eryksun Feb 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

The value of args should quote comspec. Otherwise the shell process won't parse its command line correctly if comspec contains spaces.

Copy link
Copy Markdown
Member Author

zooba Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

That was a problem before too, so let's make it a new issue. Assuming the backports for the original change go it, it'll automatically flow back smoothly enough (whereas this PR may not).

zooba mentioned this pull request Feb 8, 2023
Open
zooba merged commit 20cf32e into python:main Feb 8, 2023
zooba deleted the gh-101283 branch February 8, 2023 23:39
This was referenced Feb 9, 2023
Merged
Merged
Merged
Copy link
Copy Markdown
Member

arhadthedev commented Feb 9, 2023

@zooba @eryksun Should this PR be backported? Especially considering that the new security releases may be issued the nearest days because of #101726 (comment):

However, I'm also concerned by the near certainty that we'll be criticised (again) for not immediately reacting, so if we'd rather not keep patiently explaining to nervous people that we aren't impacted, we could schedule new releases.

Copy link
Copy Markdown
Member Author

zooba commented Feb 9, 2023

I integrated the fix into the backports before merging them, so it's already there.

Copy link
Copy Markdown
Member

arhadthedev commented Feb 9, 2023

Oh, I see, thank you.

carljm added a commit to carljm/cpython that referenced this pull request Feb 9, 2023
Merge branch 'main' into inlinecomp2 …
be3becc
* main: (82 commits) pythongh-101670: typo fix in PyImport_ExtendInittab() (python#101723) pythonGH-99293: Document that `Py_TPFLAGS_VALID_VERSION_TAG` shouldn't be used. (#pythonGH-101736) no-issue: Add Dong-hee Na as the cjkcodecs codeowner (pythongh-101731) pythongh-101678: Merge math_1_to_whatever() and math_1() (python#101730) pythongh-101678: refactor the math module to use special functions from c11 (pythonGH-101679) pythongh-85984: Remove legacy Lib/pty.py code. (python#92365) pythongh-98831: Use opcode metadata for stack_effect() (python#101704) pythongh-101283: Version was just released, so should be changed in 3.11.3 (pythonGH-101719) pythongh-101283: Fix use of unbound variable (pythonGH-101712) pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286) pythongh-101277: Port more itertools static types to heap types (python#101304) pythongh-98831: Modernize CALL and family (python#101508) pythonGH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (python#101697) pythongh-100221: Fix creating dirs in `make sharedinstall` (pythonGH-100329) pythongh-101670: typo fix in PyImport_AppendInittab() (pythonGH-101672) pythongh-101196: Make isdir/isfile/exists faster on Windows (pythonGH-101324) pythongh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (pythonGH-101615) pythongh-100933: Improve `check_element` helper in `test_xml_etree` (python#100934) pythonGH-101578: Normalize the current exception (pythonGH-101607) pythongh-47937: Note that Popen attributes are read-only (python#93070) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eryksun eryksun left review comments

gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.