← 返回首页
gh-101152: Implement PEP 699 by ramvikrams · Pull Request #101193 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-101152: Implement PEP 699#101193

Merged
Fidget-Spinner merged 16 commits into
python:mainfrom
ramvikrams:t001
Jan 24, 2023
Merged

gh-101152: Implement PEP 699#101193
Fidget-Spinner merged 16 commits into
python:mainfrom
ramvikrams:t001

Conversation

ramvikrams commented Jan 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

gh-101152: Added the PEP 699 Implementation

bedevere-bot mentioned this pull request Jan 20, 2023
Closed

Fidget-Spinner commented Jan 21, 2023

Copy link
Copy Markdown
Member
  1. Please add news.
  2. The code looks similar to Kumar's. I'll add him as co-author when I merge.

ramvikrams commented Jan 21, 2023

Copy link
Copy Markdown
Contributor Author
  1. Please add news.
  2. The code looks similar to Kumar's. I'll add him as co-author when I merge.

added the news and infact it is a replica of his solution

Fidget-Spinner reviewed Jan 21, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Build/2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst Outdated Show resolved Hide resolved
Fidget-Spinner reviewed Jan 21, 2023
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Just some feedback for your future contributions:

  1. You can close conversations. Click on the "resolve conversation" button once you feel that you resolved the comment.
  2. reStructuredText markup is a little tricky! So you can refer to the devguide for that https://devguide.python.org/documentation/markup/
  3. I'll try to summarise what I look for in the Whats New deprecation. First you want to know exactly what is being affected (in this case the field of a certain struct being deprecated). Secondly, you want to know, without ambiguity, how we will notify users of this deprecation. In this case it's a compiler warning. Lastly, if there's a planned removal version for the deprecated thing, it should be mentioned too.

Thank you.

Comment thread Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Comment thread Misc/NEWS.d/next/Build/2023-01-21-10-31-35.gh-issue-101152.xvM8pL.rst Outdated Show resolved Hide resolved
Comment thread Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Fidget-Spinner changed the title gh-101152: Added the PEP 699 Implementation gh-101152: Implement PEP 699 Jan 21, 2023
ramvikrams and others added 2 commits January 21, 2023 21:27
Update Doc/whatsnew/3.12.rst …
a799bfb
Co-authored-by: Ken Jin <kenjin@python.org>
Update Misc/NEWS.d/next/Build/2023-01-21-10-31-35.gh-issue-101152.xvM… …
8b88d8e
…8pL.rst Co-authored-by: Ken Jin <kenjin@python.org>

ramvikrams commented Jan 21, 2023

Copy link
Copy Markdown
Contributor Author

Just some feedback for your future contributions:

The feedback was very helpful, will surely keep the points in mind.

Thanks

Fidget-Spinner reviewed Jan 21, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Fidget-Spinner reviewed Jan 22, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
kumaraditya303 approved these changes Jan 23, 2023
View reviewed changes

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM

Fidget-Spinner commented Jan 23, 2023

Copy link
Copy Markdown
Member

Can you rebase with main and fix the conflicts in 3.12 whats new please? Seems like someone wrote an entry at the current spot.

ramvikrams commented Jan 23, 2023

Copy link
Copy Markdown
Contributor Author

Can you rebase with main and fix the conflicts in 3.12 whats new please? Seems like someone wrote an entry at the current spot.

yes sure

Fidget-Spinner merged commit 7f95ec3 into python:main Jan 24, 2023
ramvikrams deleted the t001 branch January 24, 2023 10:42
vstinner mentioned this pull request Sep 22, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Fidget-Spinner Fidget-Spinner approved these changes
kumaraditya303 kumaraditya303 approved these changes

Assignees

Fidget-Spinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.