← 返回首页
[3.11] Clarify re docs for byte pattern group names (GH-99308) by Kentzo · Pull Request #101001 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

[3.11] Clarify re docs for byte pattern group names (GH-99308)#101001

Merged
hauntsaninja merged 1 commit into
python:3.11from
GreatFruitOmsk:fix-re-docstring-3.11
Mar 4, 2023
Merged

[3.11] Clarify re docs for byte pattern group names (GH-99308)#101001
hauntsaninja merged 1 commit into
python:3.11from
GreatFruitOmsk:fix-re-docstring-3.11

Conversation

Kentzo commented Jan 12, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Jan 12, 2023
Closed
bedevere-bot added docs Documentation in the Doc dir skip news labels Jan 12, 2023

slateny commented Jan 14, 2023

Copy link
Copy Markdown
Contributor

Per comment I don't believe there should be a backport for this.

Kentzo commented Jan 14, 2023

Copy link
Copy Markdown
Contributor Author

#99308 (comment) says otherwise

CAM-Gerlach reviewed Jan 14, 2023
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks @Kentzo . One set of suggestions, otherwise LGTM

Comment thread Doc/library/re.rst Show resolved Hide resolved
Comment thread Doc/library/re.rst Show resolved Hide resolved
Comment thread Doc/library/re.rst Show resolved Hide resolved
hauntsaninja approved these changes Jan 17, 2023
View reviewed changes

hauntsaninja left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks for backporting this!

Looks like it's common enough for past versions of docs to contain "removed" for future versions of Python, so would you mind applying CAM's suggestions?

Edit: Since this has been lying around, I think this is fine to merge as is without the more specific directives; 3.12 isn't finalised and this seems like a short time between deprecation and removal.

hauntsaninja merged commit cda1d52 into python:3.11 Mar 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CAM-Gerlach CAM-Gerlach left review comments
hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.