Sorry, something went wrong.
|
I think this could skip news? 🤔 |
Sorry, something went wrong.
|
Confirming this resolves the issues for Django ✔️ Thanks! |
Sorry, something went wrong.
| while ismethod(f): | ||
| f = f.__func__ | ||
| f = functools._unwrap_partial(f) | ||
| if not (isfunction(f) or _signature_is_functionlike(f)): |
There was a problem hiding this comment.
What else can we mark as coroutine-like? Functions, methods, other callables like partial, classes. Anything else?
Sorry, something went wrong.
There was a problem hiding this comment.
Hi @sobolevn. I'm not sure I follow 🤔
The cases that have occurred up to Python 3.11, using the old asyncio version, have been callable classes and sync functions. Those are (now) covered. We also added tests for static and class method and lambdas (but I've not seen anyone using those).
The other case that would simplify client code is automatic detection of the __call__ method (either async def or marked) but I think the preference is not to add that.
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM. I will merge this.
Sorry, something went wrong.
The initial implementation did not correctly identify explicitly marked class instances.
Follow up to 532aa4e from #99247
(Bug in Python 3.12.0a4)
Integrating Python 3.12.0a4 with the Django test suite we see that the _has_coroutine_mark() is not allowing the key case of a class being marked as an asynchronous callable. (This is my fault: in the discussion with @gvanrossum on #99247 over whether we'd cover the marked and async def __call__ cases automatically, I forgot to add the explicit test for the marked instances.)
I note the isfunction(f) or _signature_is_functionlike(f) restriction is untested, and not, I think, necessary. (If folks applied markcoroutinefunction, I think we have to assume that they know what they're up to.)