← 返回首页
gh-100739: Respect mock spec when checking for unsafe prefixes by cklein · Pull Request #100740 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-100739: Respect mock spec when checking for unsafe prefixes#100740

Merged
cjw296 merged 2 commits into
python:mainfrom
cklein:allow-spec
Jan 4, 2023
Merged

gh-100739: Respect mock spec when checking for unsafe prefixes#100740
cjw296 merged 2 commits into
python:mainfrom
cklein:allow-spec

Conversation

cklein commented Jan 4, 2023 •
edited by AlexWaygood
Loading

Copy link
Copy Markdown
Contributor

Respect Mock spec for attribute names starting with assert (and typos)

cklein requested a review from cjw296 as a code owner January 4, 2023 07:24
bedevere-bot mentioned this pull request Jan 4, 2023
Closed

bedevere-bot commented Jan 4, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

sobolevn reviewed Jan 4, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2023-01-04-09-53-38.gh-issue-100740.-j5UjI.rst Outdated Show resolved Hide resolved
Comment thread Lib/test/test_unittest/testmock/testmock.py Show resolved Hide resolved
cklein requested review from sobolevn and removed request for cjw296 January 4, 2023 10:24
sobolevn requested review from cjw296 and removed request for sobolevn January 4, 2023 10:28
carljm reviewed Jan 4, 2023
View reviewed changes
Comment thread Lib/test/test_unittest/testmock/testmock.py Show resolved Hide resolved

carljm commented Jan 4, 2023

Copy link
Copy Markdown
Member

(Note, generally don't ever force-push to a PR, it disrupts incremental review. The commits will be squashed on merge anyway, so there's no harm in having the PR be a series of commits reflecting its development.)

carljm approved these changes Jan 4, 2023
View reviewed changes

carljm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

This LGTM, thanks for the fix!

cjw296 merged commit 7f1eefc into python:main Jan 4, 2023
AlexWaygood added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 4, 2023

miss-islington commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @cklein for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @cklein for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot commented Jan 4, 2023

Copy link
Copy Markdown

GH-100760 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 4, 2023

bedevere-bot commented Jan 4, 2023

Copy link
Copy Markdown

GH-100761 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 4, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2023
pythongh-100739: Respect mock spec when checking for unsafe prefixes (p… …
9cbfcc8
…ythonGH-100740) (cherry picked from commit 7f1eefc) Co-authored-by: Christian Klein <167265+cklein@users.noreply.github.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2023
pythongh-100739: Respect mock spec when checking for unsafe prefixes (p… …
f07d620
…ythonGH-100740) (cherry picked from commit 7f1eefc) Co-authored-by: Christian Klein <167265+cklein@users.noreply.github.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 4, 2023
gh-100739: Respect mock spec when checking for unsafe prefixes (GH-10… …
541e7b8
…0740) (cherry picked from commit 7f1eefc) Co-authored-by: Christian Klein <167265+cklein@users.noreply.github.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 4, 2023
gh-100739: Respect mock spec when checking for unsafe prefixes (GH-10… …
f49cc3c
…0740) (cherry picked from commit 7f1eefc) Co-authored-by: Christian Klein <167265+cklein@users.noreply.github.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
carljm added a commit to carljm/cpython that referenced this pull request Jan 5, 2023
Merge branch 'main' into fieldrepr …
60aa562
* main: pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753) pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702) Drop myself from pathlib maintenance (python#100757) pythongh-100739: Respect mock spec when checking for unsafe prefixes (python#100740)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sobolevn sobolevn left review comments
carljm carljm approved these changes
cjw296 cjw296 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Footer

© 2026 GitHub, Inc.