GH-100485: Add math.sumprod()#100677

rhettinger

Issue: Consider adding sumproduct() or dotproduct() to the math module #100485

bedevere-bot

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 5f4e493 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

bedevere-bot

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 5f4e493 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit ec50404 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

bedevere-bot

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit ec50404 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 2e772cb 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 2e772cb 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

rhettinger added 9 commits January 1, 2023 17:29

Stub function.

5776b0f

Core fuctionality without error handling

8ffd49e

Test core functionality.

f5a3ecb

Add docs

37fcb0a

Check for non-iterable inputs

6cfc5cc

Handle uneven lengths and error returns from PyIter_Next().

fbeca6b

Handle errors arising during the multiplications or additions.

40cfc8f

Test special values

2ac24f5

Add blurb

1a64fd8

rhettinger added type-feature A feature request or enhancement 3.12 only security fixes labels Jan 2, 2023

rhettinger requested a review from tim-one January 2, 2023 03:59

bedevere-bot added the awaiting core review label Jan 2, 2023

bedevere-bot mentioned this pull request Jan 2, 2023

Consider adding sumproduct() or dotproduct() to the math module #100485

Closed

Regenerate clinic files

5f4e493

rhettinger added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 2, 2023

bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 2, 2023

rhettinger added 9 commits January 3, 2023 11:32

Beautify with booleans.

31fa258

Add int_path. Needs work on refcount and addition overflow.

d19a38b

Add more assertions and refcount fixes

a28fd71

Only test for ints when iterators are not stopped.

f998ee4

Test long addition for overflow

94a9cbd

Improve wording regarding extended precision.

c778865

Add the "finished" summary variable for readability.

6d619dd

Add flt path

83dbf96

add flt/int path

c2e5f3d

rhettinger added 9 commits January 4, 2023 22:26

Fully encapsulate the dl (double length) logic.

9b03468

Add performance comment.

8b88f4d

Write tight.

83ca929

Abbreviate comment.

708f314

Remove case for int/int while float in use.

90f1ee4

Beautify dl_add()

02035dc

Add stress tests.

9b1edcc

Update itertools recipe to reflect the promotion.

22249d6

Remove doctest for dotproduct().

ec50404

rhettinger added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 5, 2023

bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 5, 2023

rhettinger added 7 commits January 6, 2023 09:43

Speed-up iterator access. Let float be selected by bools.

19dfd08

Add assertion for a key checkpoint

13f1d4f

Move dl_mul() out to a separate function. Dekker (5.8).

a07e03d

Add the smaller magnitude component first.

d274325

Use Dekker (5.12) directly. Avoids calling dl_add() and saves a compa… …

67f82ca

…rison.

Update timing in comment.

5d165be

Add in the large component first.

2e772cb

rhettinger added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 7, 2023

bedevere-bot removed 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 7, 2023

rhettinger merged commit 47b9f83 into python:main Jan 7, 2023

bedevere-bot removed the awaiting core review label Jan 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

GH-100485: Add math.sumprod()#100677