← 返回首页
gh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries by Fidget-Spinner · Pull Request #100492 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries#100492

Closed
Fidget-Spinner wants to merge 7 commits into
python:mainfrom
Fidget-Spinner:more_load_attr
Closed

gh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries#100492
Fidget-Spinner wants to merge 7 commits into
python:mainfrom
Fidget-Spinner:more_load_attr

Conversation

Fidget-Spinner commented Dec 24, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Dec 24, 2022
Closed
2 tasks
Fidget-Spinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 24, 2022

bedevere-bot commented Dec 24, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 576c914 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 24, 2022
brandtbucher reviewed Dec 27, 2022
View reviewed changes
Comment thread Python/bytecodes.c Outdated Show resolved Hide resolved

markshannon commented Jan 3, 2023

Copy link
Copy Markdown
Member

The stats show only a small increase in specialization effectiveness, and that the new instruction has a 40% miss rate.

I think we would be better off trying to reduce the number of objects with dictionaries than specializing for that case.

Fidget-Spinner commented Jan 3, 2023

Copy link
Copy Markdown
Member Author

Hmm yes hit rate only went from 82.0% to 82.5%. This isn't worthwhile.

Fidget-Spinner deleted the more_load_attr branch January 4, 2023 11:53
ericsnowcurrently mentioned this pull request Jan 4, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher left review comments
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.