← 返回首页
gh-100001: Also escape \s in http.server log messages. by gpshead · Pull Request #100038 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-100001: Also escape \s in http.server log messages.#100038

Merged
gpshead merged 1 commit into
python:mainfrom
gpshead:http.server/log/3.12
Dec 5, 2022
Merged

gh-100001: Also escape \s in http.server log messages.#100038
gpshead merged 1 commit into
python:mainfrom
gpshead:http.server/log/3.12

Conversation

Copy link
Copy Markdown
Member

gpshead commented Dec 5, 2022 •
edited by bedevere-bot
Loading

Also \ escape \s in the http.server BaseHTTPRequestHandler.log_message so that it is technically possible to parse the line and reconstruct what the original data was. Without this a \xHH is ambiguious as to if it is a hex replacement we put in or the characters r"\x" came through in the original request line.

pythongh-100001: Also escape \s in http.server log messages. …
0b4b5ed
Also \ escape \s in the http.server BaseHTTPRequestHandler.log_message so that it is technically possible to parse the line and reconstruct what the original data was. Without this a \xHH is ambiguious as to if it is a hex replacement we put in or the characters r"\x" came through in the original request line.
gpshead added the needs backport to 3.11 only security fixes label Dec 5, 2022
gpshead requested a review from vstinner December 5, 2022 21:56
bedevere-bot mentioned this pull request Dec 5, 2022
Closed
gpshead added the needs backport to 3.10 only security fixes label Dec 5, 2022
gpshead added a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
also escape \s (backport of PR python#100038).
6df2dd2
gpshead added a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
also escape \s (backport of PR python#100038).
feaeb00
gpshead added a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
also escape \s (backport of PR python#100038).
60779c3
gpshead merged commit 7e29398 into python:main Dec 5, 2022
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 5, 2022

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

gpshead deleted the http.server/log/3.12 branch December 5, 2022 22:27
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
pythongh-100001: Also escape \s in http.server log messages. (pythonG… …
8d34664
…H-100038) Also \ escape \s in the http.server BaseHTTPRequestHandler.log_message so that it is technically possible to parse the line and reconstruct what the original data was. Without this a \xHH is ambiguious as to if it is a hex replacement we put in or the characters r"\x" came through in the original request line. (cherry picked from commit 7e29398) Co-authored-by: Gregory P. Smith <greg@krypto.org>
Copy link
Copy Markdown

bedevere-bot commented Dec 5, 2022

GH-100040 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
pythongh-100001: Also escape \s in http.server log messages. (pythonG… …
93bd81b
…H-100038) Also \ escape \s in the http.server BaseHTTPRequestHandler.log_message so that it is technically possible to parse the line and reconstruct what the original data was. Without this a \xHH is ambiguious as to if it is a hex replacement we put in or the characters r"\x" came through in the original request line. (cherry picked from commit 7e29398) Co-authored-by: Gregory P. Smith <greg@krypto.org>
Copy link
Copy Markdown

bedevere-bot commented Dec 5, 2022

GH-100041 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 5, 2022
miss-islington added a commit that referenced this pull request Dec 5, 2022
gh-100001: Also escape \s in http.server log messages. (GH-100038) …
aae7b43
Also \ escape \s in the http.server BaseHTTPRequestHandler.log_message so that it is technically possible to parse the line and reconstruct what the original data was. Without this a \xHH is ambiguious as to if it is a hex replacement we put in or the characters r"\x" came through in the original request line. (cherry picked from commit 7e29398) Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this pull request Dec 5, 2022
gh-100001: Also escape \s in http.server log messages. (GH-100038) …
b2ff0f7
Also \ escape \s in the http.server BaseHTTPRequestHandler.log_message so that it is technically possible to parse the line and reconstruct what the original data was. Without this a \xHH is ambiguious as to if it is a hex replacement we put in or the characters r"\x" came through in the original request line. (cherry picked from commit 7e29398) Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this pull request Dec 6, 2022
[3.8] gh-100001: Omit control characters in http.server stderr logs. (G… …
e43393a
…H-100002) (#100033) * gh-100001: Omit control characters in http.server stderr logs. (GH-100002) Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to. (cherry picked from commit d8ab0a4) Co-authored-by: Gregory P. Smith <greg@krypto.org> * also escape \s (backport of PR #100038). * add versionadded and remove extraneous 'to' Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this pull request Dec 6, 2022
[3.9] gh-100001: Omit control characters in http.server stderr logs. (G… …
3b81c13
…H-100002) (#100032) * gh-100001: Omit control characters in http.server stderr logs. (GH-100002) Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to. (cherry picked from commit d8ab0a4) Co-authored-by: Gregory P. Smith <greg@krypto.org> * also escape \s (backport of PR #100038). * add versionadded and remove extra 'to' Co-authored-by: Gregory P. Smith <greg@krypto.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.