← 返回首页
gh-72719: Remove deprecated `asyncore` and `asynchat` modules by sobolevn · Pull Request #96580 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

gh-72719: Remove deprecated asyncore and asynchat modules#96580

Merged
vstinner merged 7 commits into
python:mainfrom
sobolevn:issue-72719
Nov 8, 2022
Merged

gh-72719: Remove deprecated asyncore and asynchat modules#96580
vstinner merged 7 commits into
python:mainfrom
sobolevn:issue-72719

Conversation

sobolevn commented Sep 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Several notes:

  1. I followed the same path as smtpd in gh-93243: Make smtpd private before porting its users #93246 It was suggested in Remove asyncore, asynchat and smtpd modules #72719 (comment) by @vstinner
  2. I've added TODO items about completely removing these modules in the future

PEP: https://peps.python.org/pep-0594/

sobolevn requested review from a team and vsajip as code owners September 5, 2022 14:18
sobolevn commented Sep 5, 2022
View reviewed changes
Comment thread .github/CODEOWNERS Show resolved Hide resolved
sobolevn force-pushed the issue-72719 branch 2 times, most recently from 92a5bab to 97d7bc8 Compare September 5, 2022 14:29
sobolevn requested a review from giampaolo September 5, 2022 14:31
theLastOfCats reviewed Sep 5, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved

arhadthedev commented Sep 25, 2022

Copy link
Copy Markdown
Member

I think it would be great to have this PR merged before 3.12.0a1 (3 October, 2022, after 7 days) to allow third party library maintainers and early adopters to report scenarios possible in asyncore but not in asyncio as soon as possible.

sobolevn commented Sep 25, 2022

Copy link
Copy Markdown
Member Author

Ping @pablogsal as release manager 🙂

pablogsal commented Sep 25, 2022

Copy link
Copy Markdown
Member

Ping @pablogsal as release manager 🙂

Thanks for checking with me! One note, the RM for 3.12 is @Yhg1s so he should probably also take a look

sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 25, 2022

bedevere-bot commented Sep 25, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 99e3de9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 25, 2022
arhadthedev mentioned this pull request Oct 3, 2022
Closed
12 tasks

arhadthedev commented Oct 6, 2022

Copy link
Copy Markdown
Member

@Yhg1s Is there any chance to get this PR accepted into 3.12.0a1? It seems we've got some extra time until the release blockers are resolved.

JelleZijlstra reviewed Oct 7, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jUpzF3.rst Outdated Show resolved Hide resolved
Update Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jU… …
9a49615
…pzF3.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
hugovk reviewed Oct 28, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Show resolved Hide resolved
hugovk mentioned this pull request Oct 28, 2022
Closed
sobolevn mentioned this pull request Oct 29, 2022
Merged
vstinner reviewed Nov 3, 2022
View reviewed changes
Comment thread Lib/test/support/asynchat.py Outdated Show resolved Hide resolved
Comment thread Lib/test/support/asyncore.py Outdated Show resolved Hide resolved
Comment thread Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jUpzF3.rst Outdated
@@ -0,0 +1,3 @@
Remove modules :mod:`asyncore` and :mod:`asynchat`, which were deprecated by :pep:`594`.

They are temporarily moved to :mod:`test.support` so some other tests that rely on them keep working.

vstinner Nov 3, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

I suggest to remove the second sentence. I prefer to hide them as well as possible :-)

sobolevn Nov 5, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Done, thank you for the review!

bedevere-bot mentioned this pull request Nov 5, 2022
Closed
vstinner reviewed Nov 7, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Please remove last references:

  • Doc/library/socketserver.rst
  • Doc/license.rst: update the module names

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

vstinner commented Nov 7, 2022

Copy link
Copy Markdown
Member

When I removed the module last year (commit), I even renamed the asyncore module to test.support._asyncore. But I don't mind to call it test.support.asyncore.

giampaolo commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

sure, no problem

sobolevn commented Nov 7, 2022

Copy link
Copy Markdown
Member Author

Done, all three - removed!

vstinner reviewed Nov 7, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Oh, there is now a conflict. Can you try to rebase your PR? Or try to merge main into your PR?

Please keep the license, files are still around, they are just moved somewhere else.

Comment thread Doc/license.rst Show resolved Hide resolved
vstinner approved these changes Nov 8, 2022
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

LGTM.

vstinner merged commit e56e33d into python:main Nov 8, 2022

vstinner commented Nov 8, 2022

Copy link
Copy Markdown
Member

Merged, thanks. Let's see how it goes with Python 3.12.

sobolevn commented Nov 8, 2022

Copy link
Copy Markdown
Member Author

Thank you for your guidance and help!
I feel happy now, removing old stuff is my kinda thing 😊 🎉

vstinner commented Nov 8, 2022

Copy link
Copy Markdown
Member

See also the discussion: Collaboration on handling Python 3.12 incompatible changes (distutils removal, invalid escape escape, etc.).

opoplawski mentioned this pull request Apr 1, 2023
Closed
arhadthedev mentioned this pull request May 25, 2023
Closed
honglei mentioned this pull request Jun 18, 2023
Closed
thebeanogamer mentioned this pull request Jul 16, 2023
Open

This comment was marked as off-topic.

Sign in to view

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments
hugovk hugovk left review comments
vstinner vstinner approved these changes
vsajip Awaiting requested review from vsajip vsajip is a code owner
giampaolo Awaiting requested review from giampaolo giampaolo is a code owner
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
+2 more reviewers
theLastOfCats theLastOfCats left review comments
SreekanthModupalli SreekanthModupalli left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Footer

© 2026 GitHub, Inc.