Sorry, something went wrong.
|
I've pushed my naive attempt to fix gdb: since it only needs a current line f->f_lineno seems like a tool for the job. (again, this is my very first time working with gdb) |
Sorry, something went wrong.
|
Failures do not seem related 🤔 |
Sorry, something went wrong.
|
test_implied_dirs_performance issue was fixed in gh-102225 so merging main should help. |
Sorry, something went wrong.
|
@markshannon do you have time to re-review this, please? :) |
Sorry, something went wrong.
|
@carljm maybe you can have a look? :) |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good in general.
We aren't obliged to remove co_lnotab in 3.14, but we can. Perhaps change the "will"s to "may"s.
Not sure what to do about Misc/gdbinit though.
Sorry, something went wrong.
|
Perhaps we should discuss the future of Misc/gdbinit in another issue, and not worry about it here. |
Sorry, something went wrong.
|
@markshannon thanks a lot for your review and for all your hard work on CPython!
|
Sorry, something went wrong.
|
Shall we add a .. deprecated-removed: 3.12 3.14 in the main docs, somewhere near https://docs.python.org/3.12/reference/datamodel.html?highlight=co_lnotab ? |
Sorry, something went wrong.
|
I think that we can add "is deprecated since 3.12 and may be removed in 3.14". |
Sorry, something went wrong.
|
I think that we can add "is deprecated since 3.12 and may be removed in 3.14". Sure, let's do something like that. |
Sorry, something went wrong.
|
@markshannon I've solved the merge conflicts. I hope that this is ready to be merged when you have the time :) |
Sorry, something went wrong.
I still have to fix these lines:
cpython/Misc/gdbinit
Lines 60 to 61 in 6ef6915
But, since I have 0 experience with gdb it might take some time.