← 返回首页
GH-84783: Make the slice object hashable by furkanonder · Pull Request #101264 · python/cpython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

GH-84783: Make the slice object hashable#101264

Merged
rhettinger merged 15 commits into
python:mainfrom
furkanonder:issue-84783
Feb 19, 2023
Merged

GH-84783: Make the slice object hashable#101264
rhettinger merged 15 commits into
python:mainfrom
furkanonder:issue-84783

Conversation

furkanonder commented Jan 23, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Jan 23, 2023
Closed
rhettinger requested changes Feb 5, 2023
View reviewed changes
Comment thread Objects/sliceobject.c Show resolved Hide resolved

bedevere-bot commented Feb 5, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

rhettinger requested changes Feb 5, 2023
View reviewed changes

rhettinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

We do need to add a NEWS blurb and a versionchanged entry to the docs.

bedevere-bot commented Feb 5, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

rhettinger commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

We're getting some test failures:

====================================================================== [3683](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3684) ERROR: test_sequence_del_slice (test.test_capi.test_misc.CAPITest.test_sequence_del_slice) [3684](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3685) ---------------------------------------------------------------------- [3685](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3686) Traceback (most recent call last): [3686](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3687) File "/Users/runner/work/cpython/cpython/Lib/test/test_capi/test_misc.py", line 459, in test_sequence_del_slice [3687](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3688) _testcapi.sequence_del_slice(mapping, 1, 3) [3688](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3689) KeyError: slice(1, 3, None) [3689](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3690) [3690](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3691) ====================================================================== [3691](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3692) FAIL: test_sequence_set_slice (test.test_capi.test_misc.CAPITest.test_sequence_set_slice) [3692](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3693) ---------------------------------------------------------------------- [3693](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3694) Traceback (most recent call last): [3694](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3695) File "/Users/runner/work/cpython/cpython/Lib/test/test_capi/test_misc.py", line 419, in test_sequence_set_slice [3695](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3696) with self.assertRaises(TypeError): [3696](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3697) AssertionError: TypeError not raised [3697](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3698)

rhettinger reviewed Feb 5, 2023
View reviewed changes
Comment thread Objects/sliceobject.c Show resolved Hide resolved

OTheDev commented Feb 11, 2023

Copy link
Copy Markdown
Contributor

It looks like the following test needs to be removed or changed as the expected behaviour would now be a KeyError as slice objects would now be valid as keys.

cpython/Lib/test/test_capi/test_misc.py

Lines 457 to 460 in b652d40

mapping = {1: 'a', 2: 'b', 3: 'c'}
with self.assertRaises(TypeError):
_testcapi.sequence_del_slice(mapping, 1, 3)
self.assertEqual(mapping, {1: 'a', 2: 'b', 3: 'c'})

The following test can probably be modified to reflect the fact that mapping[1:3] = 'xy' would be valid and that

mapping == {1: 'a', 2: 'b', 3: 'c', slice(1, 3, None): 'xy'}

is true afterwards:

cpython/Lib/test/test_capi/test_misc.py

Lines 418 to 421 in b652d40

mapping = {1: 'a', 2: 'b', 3: 'c'}
with self.assertRaises(TypeError):
_testcapi.sequence_set_slice(mapping, 1, 3, 'xy')
self.assertEqual(mapping, {1: 'a', 2: 'b', 3: 'c'})

OTheDev reviewed Feb 11, 2023
View reviewed changes
Comment thread Lib/test/test_slice.py Show resolved Hide resolved
OTheDev reviewed Feb 12, 2023
View reviewed changes
Comment thread Doc/library/functions.rst Outdated Show resolved Hide resolved

OTheDev commented Feb 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please correct me if I am wrong, but it looks like test_doctest() is failing because

cpython/Lib/test/test_doctest.py

Line 710 in 3eb12df

>>> 825 < len(tests) < 845 # approximate number of objects with docstrings
needs to be relaxed (increased) a bit. It seems to just be at the limit. Non-debug build passes (with len(tests) at 844) but debug build adds one to len(tests) (making it 845). Looking at the commit history, it looks like it needs modifying every now and then.

@iritkatriel Apologies, but it looks like you were the last to modify this line. Does this sound about right to you?

EDIT: I think I've figured it out (below)!

OTheDev commented Feb 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@furkanonder

I think I understand now why test_doctests() is failing.

On my system, if I clone main, build it normally (non-debug), and compute len(tests) (see previous comment), I get 843.

Now, if I clone your branch, build it normally (non-debug), I get 844 instead. The extra entry to tests is <DocTest builtins.slice.__hash__ from builtins:None (no examples)>, which isn't an element of tests on main.

Now, running the tests (on your branch) with non-debug mode succeeds on my system.

Once we build with --with-pydebug, however, this adds an additional entry to tests, namely, <DocTest builtins.set.test_c_api from builtins:None (no examples)> (whether on your branch or main), making the number on your branch 845, which makes

cpython/Lib/test/test_doctest.py

Line 710 in 3eb12df

>>> 825 < len(tests) < 845 # approximate number of objects with docstrings

fail.

So, I think what needs to be done now is for you to modify that line in test_doctest.py, say, to

>>> 830 < len(tests) < 850

I have verified that test_doctests() passes after this change (both on non-debug and debug builds).

For reference:

>>> import builtins, doctest >>> tests = doctest.DocTestFinder().find(builtins)

OTheDev and others added 2 commits February 12, 2023 21:36
Update test_doctest.py
0c78cfc
Update Doc/library/functions.rst …
cff08dd
Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
9 hidden items Load more…
furkanonder requested a review from OTheDev February 12, 2023 23:02
OTheDev reviewed Feb 13, 2023
View reviewed changes
Comment thread Lib/test/test_slice.py Outdated Show resolved Hide resolved
OTheDev reviewed Feb 13, 2023
View reviewed changes
Comment thread Lib/test/test_slice.py Show resolved Hide resolved
rhettinger merged commit 61f1e67 into python:main Feb 19, 2023
carljm added a commit to carljm/cpython that referenced this pull request Feb 20, 2023
Merge branch 'main' into inlinecomp2 …
9f0fc5b
* main: (60 commits) pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078) pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012) pythongh-101566: Sync with zipp 3.14. (pythonGH-102018) pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161) pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074) pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912) pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949) pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070) pythongh-97786: Fix compiler warnings in pytime.c (python#101826) pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962) Misc improvements to the float tutorial (pythonGH-102052) pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046) pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854) Add missing 'is' to `cmath.log()` docstring (python#102049) pythongh-100210: Correct the comment link for unescaping HTML (python#100212) pythongh-97930: Also include subdirectory in makefile. (python#102030) pythongh-99735: Use required=True in argparse subparsers example (python#100927) Fix incorrectly documented attribute in csv docs (python#101250) pythonGH-84783: Make the slice object hashable (pythonGH-101264) ...
carljm added a commit to carljm/cpython that referenced this pull request Feb 22, 2023
Merge branch 'main' into inlinecomp …
544b30c
* main: (225 commits) pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078) pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012) pythongh-101566: Sync with zipp 3.14. (pythonGH-102018) pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161) pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074) pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912) pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949) pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070) pythongh-97786: Fix compiler warnings in pytime.c (python#101826) pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962) Misc improvements to the float tutorial (pythonGH-102052) pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046) pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854) Add missing 'is' to `cmath.log()` docstring (python#102049) pythongh-100210: Correct the comment link for unescaping HTML (python#100212) pythongh-97930: Also include subdirectory in makefile. (python#102030) pythongh-99735: Use required=True in argparse subparsers example (python#100927) Fix incorrectly documented attribute in csv docs (python#101250) pythonGH-84783: Make the slice object hashable (pythonGH-101264) ...
Yhg1s added a commit to Yhg1s/cpython that referenced this pull request Mar 9, 2023
Document pythonGH-101264 (Make the slice object hashable) in What's New.
7c4a026
Yhg1s added a commit that referenced this pull request Mar 9, 2023
GH-84783: Document GH-101264 (Make the slice object hashable) in What… …
58d761e
…'s New. (#102548)
furkanonder added a commit to furkanonder/cpython that referenced this pull request Mar 31, 2023
Mention Author for pythonGH-101264 (Make the slice object hashable)
b1edad1
terryjreedy added a commit that referenced this pull request Mar 31, 2023
GH-84783: Mention Author for GH-101264 (make slices hashable) (#103146) …
048d624
Will Bradshaw contributed original patch on bpo-40603. --------- Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
pythonGH-84783: Mention Author for pythonGH-101264 (make slices hasha… …
7ef1570
…ble) (python#103146) Will Bradshaw contributed original patch on bpo-40603. --------- Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
zzzeek mentioned this pull request May 22, 2023
Closed
lithomas1 mentioned this pull request Jul 11, 2023
Merged
5 tasks
sondreso mentioned this pull request Nov 24, 2023
Merged
tehunter mentioned this pull request Mar 27, 2024
Closed
3 tasks
davidosterberg mentioned this pull request Nov 21, 2024
Closed
jaanerik mentioned this pull request Jan 6, 2026
Merged
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rhettinger rhettinger requested changes
+1 more reviewer
OTheDev OTheDev left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.