Add `full_name` property to `User` and `Chat` objects by alissonlauffer · Pull Request #1194 · pyrogram/pyrogram · GitHub
This repository was archived by the owner on Dec 23, 2024. It is now read-only.
Conversation
meybj
pushed a commit
to meybj/pyrogram
that referenced
this pull request
Aug 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Footer
You can’t perform that action at this time.
This PR adds support for the full_name property for the User and Chat objects (since both have first_name and last_name properties).
Though I'm not sure if I should fallback to self.title inside the Chat object or just return None straightforward (the property could become a shortcut to get full names for all chat types, like a name property). Suggestions are welcome.