← 返回首页
Upgrade to Pyproject.toml by Zoe-openi · Pull Request #1240 · pre-commit/pre-commit-hooks · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Upgrade to Pyproject.toml#1240

Closed
Zoe-openi wants to merge 2 commits into
pre-commit:mainfrom
Zoe-openi:pyproject.toml
Closed

Upgrade to Pyproject.toml#1240
Zoe-openi wants to merge 2 commits into
pre-commit:mainfrom
Zoe-openi:pyproject.toml

Conversation

Copy link
Copy Markdown

pyproject.toml is the modern replacement for setup.cfg and setup.py.

This pyproject.toml was generated using ini2toml 0.15, then in the second commit the dev dependencies were moved from requirements-dev.txt to [project.optional-dependencies] dev and tox.ini amended. Tox functionality was tested and works as expected, python3 -m build also runs without issue

Copy link
Copy Markdown
Member

no it's not

asottile closed this Jan 29, 2026
Copy link
Copy Markdown
Author

no it's not

Could you please elaborate on why you would rather stay with the setup.cfg and setup.py approach?

Copy link
Copy Markdown

no it's not

Yes, it is. Please have a look at PEP 518 and PEP 621.

Copy link
Copy Markdown
Member

just because the peps exist does not mean that setup cfg is deprecated.

nobody asked for this drive by patch

Copy link
Copy Markdown
Author

Fair enough

pre-commit locked as spam and limited conversation to collaborators Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.