← 返回首页
Small fix to Histogram2dContour setup in plotly express by gmjw · Pull Request #5342 · plotly/plotly.py · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Small fix to Histogram2dContour setup in plotly express#5342

Open
gmjw wants to merge 2 commits into
plotly:mainfrom
gmjw:fix-histogram-contour-construction
Open

Small fix to Histogram2dContour setup in plotly express#5342
gmjw wants to merge 2 commits into
plotly:mainfrom
gmjw:fix-histogram-contour-construction

Conversation

Copy link
Copy Markdown
Contributor

gmjw commented Sep 5, 2025 •
edited
Loading

As per the docs, if z is passed in with no histfunc, it should be set to 'sum':

I think this corrects the intended behaviour and puts Histogram2dContour more in line with Histogram2d.

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

gmjw changed the title fix Small fix to Histogram2dContour setup in plotly express Sep 5, 2025
Copy link
Copy Markdown
Contributor Author

gmjw commented Sep 5, 2025

If a more experienced contributor takes a look at this - I can't understand why the Circle CI build has failed, the error message doesn't indicate anything clearly - any advice appreciated.

gvwilson self-assigned this Sep 9, 2025
gvwilson added P1 needed for current cycle community community contribution fix fixes something broken labels Sep 9, 2025
Copy link
Copy Markdown
Contributor

gvwilson commented Sep 9, 2025

thanks @gmjw - much appreciated. the broken Circle CI job isn't your fault - we're working on it…

Copy link
Copy Markdown
Contributor

emilykl commented Oct 1, 2025

@gmjw This looks great, thanks for the fix. The broken CI job has been fixed on main; it should pass if you merge main into this branch.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

gvwilson gvwilson approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

community community contribution fix fixes something broken P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.