← 返回首页
Fix Jasmine tests for new cloud upload button by emilykl · Pull Request #7852 · plotly/plotly.js · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Fix Jasmine tests for new cloud upload button#7852

Merged
emilykl merged 6 commits into
masterfrom
fix-tests-cloud-upload
Jun 18, 2026
Merged

Fix Jasmine tests for new cloud upload button#7852
emilykl merged 6 commits into
masterfrom
fix-tests-cloud-upload

Conversation

emilykl commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Update Jasmine tests to work with new sendChartToCloud button logic
  • Small bugfix to send chart to cloud logic
  • Re-add showEditInChartStudio config option, but mark as deprecated

emilykl force-pushed the fix-tests-cloud-upload branch from 0b5773f to ccc31df Compare June 18, 2026 19:04
emilykl marked this pull request as ready for review June 18, 2026 19:46
emilykl added the no-draftlog The associated PR doesn't require a draftlog and the CI check will be skipped. label Jun 18, 2026
emilykl requested review from camdecoster and marthacryan and removed request for camdecoster June 18, 2026 20:01
Hide details View details emilykl merged commit 67446d1 into master Jun 18, 2026
85 of 86 checks passed
emilykl deleted the fix-tests-cloud-upload branch June 18, 2026 20:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

camdecoster camdecoster approved these changes
marthacryan Awaiting requested review from marthacryan

Assignees

No one assigned

Labels

no-draftlog The associated PR doesn't require a draftlog and the CI check will be skipped.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.