← 返回首页
move cgroup pool creation logic to init by m0mosenpai · Pull Request #412 · open-lambda/open-lambda · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

move cgroup pool creation logic to init#412

Merged
tylerharter merged 8 commits into
open-lambda:mainfrom
m0mosenpai:cgroup-pool-init
Feb 20, 2026
Merged

move cgroup pool creation logic to init#412
tylerharter merged 8 commits into
open-lambda:mainfrom
m0mosenpai:cgroup-pool-init

Conversation

m0mosenpai commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • init creates the cgroup pool root dir, enables controllers and chowns to the original user (from /proc/self/loginuid)
  • NewCgroupPool() verifies the pool root exists instead of creating it
  • GroupPath() computes the cgroup path from the worker directory
  • Destroy() removes child cgroups but preserves the pool root
  • Dirty cleanup no longer removes the pool root

tylerharter requested changes Feb 18, 2026
View reviewed changes

tylerharter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Great work!

Comment thread go/worker/helpers.go Outdated Show resolved Hide resolved
Comment thread go/worker/helpers.go Outdated Show resolved Hide resolved
Comment thread go/worker/helpers.go Outdated Show resolved Hide resolved
Comment thread go/worker/commands.go Show resolved Hide resolved
tylerharter approved these changes Feb 19, 2026
View reviewed changes

tylerharter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Awesome! Mostly minor feedback

Comment thread go/common/user.go Outdated Show resolved Hide resolved
Comment thread go/common/user.go Outdated Show resolved Hide resolved
Comment thread go/worker/sandbox/cgroups/pool.go Outdated Show resolved Hide resolved
Comment thread go/worker/sandbox/cgroups/pool.go Outdated Show resolved Hide resolved
Comment thread go/worker/commands.go Outdated Show resolved Hide resolved
tylerharter approved these changes Feb 19, 2026
View reviewed changes
Comment thread go/common/user.go Outdated Show resolved Hide resolved
Comment thread go/worker/sandbox/cgroups/pool.go Outdated Show resolved Hide resolved
Comment thread go/worker/commands.go Outdated Show resolved Hide resolved
Hide details View details tylerharter merged commit a268288 into open-lambda:main Feb 20, 2026
1 of 2 checks passed
m0mosenpai added a commit to m0mosenpai/open-lambda that referenced this pull request Apr 16, 2026
Revert "move cgroup pool creation logic to init (open-lambda#412)" …
264441a
This reverts commit a268288. cgroups need to be managed by the worker itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tylerharter tylerharter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.