← 返回首页
chore(main): Exclude kiota-dom-export.txt from builds by Fryguy · Pull Request #1488 · microsoftgraph/msgraph-sdk-python · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

chore(main): Exclude kiota-dom-export.txt from builds#1488

Open
Fryguy wants to merge 1 commit into
microsoftgraph:mainfrom
Fryguy:exclude-kiota-dom-export
Open

chore(main): Exclude kiota-dom-export.txt from builds#1488
Fryguy wants to merge 1 commit into
microsoftgraph:mainfrom
Fryguy:exclude-kiota-dom-export

Conversation

Fryguy commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown

kiota-dom-export.txt is not needed at runtime and is a very large file (~32MB), contributing to a bloated package.

Fixes #1287

@lramosvea Please review. Note that I hadn't originally created this PR, because I was under the impression that this repository's content was auto-generated as I saw recent PRs from a bot updating these files.

I also wasn't sure if this was a chore or build or something else - let me know if you want it changed.

Fryguy requested a review from a team as a code owner May 19, 2026 18:27
Fryguy force-pushed the exclude-kiota-dom-export branch from 8233b9c to 408ea94 Compare May 19, 2026 18:28
chore: Exclude kiota-dom-export.txt from builds …
f03a881
kiota-dom-export.txt is not needed at runtime and is a very large file (~32MB), contributing to a bloated package.
Fryguy force-pushed the exclude-kiota-dom-export branch from 408ea94 to f03a881 Compare May 19, 2026 18:30
Fryguy changed the title Exclude kiota-dom-export.txt from builds chore(main): Exclude kiota-dom-export.txt from builds May 19, 2026
ramsessanchez requested a review from Copilot May 19, 2026 21:17
Copilot AI reviewed May 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Reduces distribution/package size by excluding a large, non-runtime text artifact (kiota-dom-export.txt) from Flit packaging inputs (per #1287).

Changes:

  • Add Flit sdist exclusion for msgraph/generated/kiota-dom-export.txt

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
Comment on lines +47 to +48
[tool.flit.sdist]
exclude = ["msgraph/generated/kiota-dom-export.txt"]
Copilot AI mentioned this pull request May 20, 2026
Open
6 tasks

Fryguy commented May 20, 2026

Copy link
Copy Markdown
Author

I am not a python expert, so I don't know if Copilot's suggestions make sense. Please advise.

Fryguy mentioned this pull request May 26, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kiota-dom-export.txt is large and included in the released package

2 participants

Footer

© 2026 GitHub, Inc.