Sorry, something went wrong.
|
Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 0cf9e30. You can monitor the build here. |
Sorry, something went wrong.
|
Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so: {
"devDependencies": {
"typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/127230/artifacts?artifactName=tgz&fileId=CCF2A5B002D81E471C51A8DB3E8BAD826F3033E0889AB91ACB94E055FA25C8E002&fileName=/typescript-4.8.0-insiders.20220601.tgz"
}
}
and then running npm install. There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.8.0-pr-48784-20".; |
Sorry, something went wrong.
|
@amcasey @andrewbranch i have highlighted important commits and the change in the description and also have left some comments during the change. Let me know if you need more details. |
Sorry, something went wrong.
|
@sheetalkamat That table's great! When you ran those scenarios, did you do any checks to determine whether the output was the same as before? Also, do you have a similar (or simpler) table for compiling TypeScript itself? |
Sorry, something went wrong.
There was a problem hiding this comment.
Your offline explanation made sense and I appreciate your thorough perf testing. I added some notes on naming and comments, but mostly I think we should check this in ASAP and see what happens.
Sorry, something went wrong.
|
I think this might have caused a regression. In my project, when I introduce errors and build with tsc -p, I get errors, as expected. When I build with tsc --build, it exits very quickly, and shows no errors. λ ./tools/tvui/node_modules/.bin/tsc -p packages/tsconfig.json
# ... expected error messages omitted
Found 3 errors in 3 files.
Errors Files
1 node_modules/relay-hooks/lib/RelayHooksTypes.d.ts:56
1 packages/@tvui/fx2-transition/src/utils.tsx:173
1 packages/@tvui/redux/testing/unitTestingEnhancer.ts:8
tvui on nth/ts-4.8 [!⇡] via v16.16.0 took 10s
λ time ./tools/tvui/node_modules/.bin/tsc --build packages/tsconfig.json --verbose
[3:52:58 PM] Projects in this build:
* packages/tsconfig.json
[3:52:58 PM] Project 'packages/tsconfig.json' is up to date but needs to update timestamps of output files that are older than input files
________________________________________________________
Executed in 550.41 millis fish external
usr time 437.83 millis 50.00 micros 437.78 millis
sys time 194.10 millis 616.00 micros 193.49 millis
--build does seem to be faster, but perhaps it's so fast that it's not doing any work. 😄 I noticed this when doing the TS 4.8 upgrade. I observe this with version 4.8.2. I'm happy to open a new issue for this if that's preferable. I first noticed this after using yarn to update type-fest in node_modules. |
Sorry, something went wrong.
|
I'm happy to open a new issue for this if that's preferable. New issue is definitively better, check if there is no similar issue. |
Sorry, something went wrong.
Commits: 16cef4a, 59ad6ef, c8327da
Commits: cb7aca3
Commits: 89d2d4c
Commits: 6e0c916
Fixes Build mode explicitly checks file stamps in watch mode rather than using file watcher events #45082
Commits: 7cb0f40, 1a8abac, 59f2b5c, dc21283, 5bccee8,
Commits: 2f2e370, fcf07f8, 15fe24e
Commits: 6198fa3,
Commits: 62c687b
Commits: 4fb6773
Commits: 0f7903d, 437619e
Commits: e6a3ee8
Commits: b32d2eb
Commits: 303824e
Commits: 28a9ff3
- During tsc --build if file timestamp is changed but its text has not, we read the file and do pseudo update (only in incremental build).
- Fixes --watch compilation with no change takes 3 seconds #31932
Commits: e4e6672 - Delete only tsbuildinfo instead of all output files when doing clean on incremental projectHere are the numbers from run on solution with large (1994) number of projects.
On Typescript Code base: