Sorry, something went wrong.
WalkthroughVersion extraction in the publish workflow is moved from setup.py to pyproject.toml. The repository removes multiple generated/OpenAPI artifacts and CI configuration files, and pyproject.toml metadata (project name and author email) is updated. Changes
Sequence Diagram(s)
sequenceDiagram
autonumber
actor GitHubActions as "Publish Workflow"
participant Repo as "Repository"
Note over GitHubActions,Repo: Old flow (before change)
GitHubActions->>Repo: read `setup.py`
Repo-->>GitHubActions: content with version string
Note over GitHubActions,Repo: New flow (after change)
GitHubActions->>Repo: grep `pyproject.toml` for "version = "
Repo-->>GitHubActions: matched version line(s)
GitHubActions->>GitHubActions: extract first match and proceed
alt no match
GitHubActions->>GitHubActions: print error & exit
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Poem🐰 Pre-merge checks and finishing touches❌ Failed checks (1 warning)
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📥 CommitsReviewing files that changed from the base of the PR and between d77c4e7 and e877f45. 📒 Files selected for processing (7)
6-6: Verify impact of package name change from "plane-python-sdk" to "plane-sdk". This is a breaking change for existing pip installations. Users with "plane-python-sdk" will need to reinstall "plane-sdk" explicitly. The PR summary indicates this is a "non-breaking change," but renaming the published package name is semantically a breaking change from a distribution/installation perspective. Ensure that:
7-7: Version extraction source updated correctly. The version is now defined in pyproject.toml and will be the single source of truth for the publish workflow. Ensure the publish workflow correctly extracts the version using the expected pattern (e.g., grep "version = "). 12-12: Author email updated to organizational account. The email change from "dev@plane.so" to "engineering@plane.so" is a reasonable organizational update. 15-17: Setuptools discovery configuration added. The package discovery configuration with include = ["plane*"] will locate all packages matching the "plane*" pattern in the repository root. Verify that all intended packages are discovered with this pattern. 19-43: Tool configurations added for code quality and testing. Added configurations for black, ruff, pytest, and mypy enable standardized tooling across the project. These are reasonable development tool configurations:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
Description
Type of Change
Summary by CodeRabbit