You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
Dismiss alert
Refers to internal code/processing logic over public API
Can be interpreted to mean DiffRow.Tags would be absent
Does not clearly disambiguate that reportLinesUnchanged is not a flag to omit the lines with DiffRow.Tag.EQUAL
I spent hours trying to figure out why setting reportLinesUnchanged to false still reports the lines that are unchanged. I had to go through the source code to figure out what this method was for.
anomal
changed the title
Fix confusing javadoc documentation for reportLinesUnWrapped
Fix confusing javadoc documentation for reportLinesUnchanged
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original javadoc comments has problems:
I spent hours trying to figure out why setting reportLinesUnchanged to false still reports the lines that are unchanged. I had to go through the source code to figure out what this method was for.