← 返回首页
Fixes #182 by parsing diffs with 'Binary files' by machadoit · Pull Request #183 · java-diff-utils/java-diff-utils · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Fixes #182 by parsing diffs with 'Binary files'#183

Merged
wumpz merged 1 commit into
java-diff-utils:masterfrom
machadoit:master
Feb 28, 2024
Merged

Fixes #182 by parsing diffs with 'Binary files'#183
wumpz merged 1 commit into
java-diff-utils:masterfrom
machadoit:master

Conversation

machadoit commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

Adds fix for #182 by parsing diff lines that start with 'Binary files'

machadoit commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

Names like testParseIssue182_add are getting flagged by Codacy, do change them to your standards, or let me know if you would like to change them. Thanks!

machadoit commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

In the meanwhile, after some more testing, and checking the fields of fromFile and toFile, there seems there is already a bug on diff blocks that don't have any changes or something like that? https://github.com/java-diff-utils/java-diff-utils/pull/184/files

This change also suffers from the same bug, and will consume more lines that it should as part of the binary file block

wumpz merged commit 54324fb into java-diff-utils:master Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.