← 返回首页
Fix duplicate keys preservation of JSON data by BoboTiG · Pull Request #1163 · httpie/cli · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Fix duplicate keys preservation of JSON data#1163

Merged
jkbrzt merged 5 commits into
httpie:masterfrom
BoboTiG:mickael/dev-303-dont-silently-fix-invalid-json-with
Sep 21, 2021
Merged

Fix duplicate keys preservation of JSON data#1163
jkbrzt merged 5 commits into
httpie:masterfrom
BoboTiG:mickael/dev-303-dont-silently-fix-invalid-json-with

Conversation

BoboTiG commented Sep 21, 2021

Copy link
Copy Markdown
Contributor

Supersedes #1136 (I messed up with remote repositories).

Fixes #1133.

codecov-commenter commented Sep 21, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1163 (21bb027) into master (4d7d6b6) will decrease coverage by 0.01%.
The diff coverage is 99.15%.

@@ Coverage Diff @@ ## master #1163 +/- ## ========================================== - Coverage 97.28% 97.26% -0.02% ========================================== Files 67 70 +3 Lines 4235 4316 +81 ========================================== + Hits 4120 4198 +78 - Misses 115 118 +3
Impacted Files Coverage Δ
httpie/output/formatters/colors.py 92.66% <83.33%> (-0.92%) ⬇️
httpie/__init__.py 100.00% <100.00%> (ø)
httpie/cli/requestitems.py 91.17% <100.00%> (ø)
httpie/output/formatters/json.py 100.00% <100.00%> (ø)
httpie/output/lexers/http.py 100.00% <100.00%> (ø)
httpie/output/lexers/json.py 100.00% <100.00%> (ø)
httpie/output/utils.py 100.00% <100.00%> (ø)
httpie/utils.py 100.00% <100.00%> (ø)
tests/fixtures/__init__.py 100.00% <100.00%> (ø)
tests/test_cli.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c5cd3...21bb027. Read the comment docs.

jkbrzt requested changes Sep 21, 2021
View reviewed changes
Comment thread httpie/utils.py Outdated Show resolved Hide resolved
Comment thread tests/test_json.py Outdated Show resolved Hide resolved
Comment thread httpie/utils.py Show resolved Hide resolved
Comment thread httpie/utils.py Show resolved Hide resolved
jkbrzt merged commit d7ed45b into httpie:master Sep 21, 2021
BoboTiG deleted the mickael/dev-303-dont-silently-fix-invalid-json-with branch September 21, 2021 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jkbrzt jkbrzt requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't silently fix invalid JSON with duplicate keys

3 participants

Footer

© 2026 GitHub, Inc.