← 返回首页
Revert "Drop support for EOL Python 3.7" by EliahKagan · Pull Request #52 · gitpython-developers/smmap · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Revert "Drop support for EOL Python 3.7"#52

Merged
Byron merged 1 commit into
gitpython-developers:masterfrom
EliahKagan:py37
Sep 17, 2023
Merged

Revert "Drop support for EOL Python 3.7"#52
Byron merged 1 commit into
gitpython-developers:masterfrom
EliahKagan:py37

Conversation

Copy link
Copy Markdown
Member

EliahKagan commented Sep 17, 2023
edited
Loading

Analogous to gitpython-developers/gitdb#94, this brings back Python 3.7 support (allowing it to be installed on 3.7, and testing on 3.7), even though 3.7 is end of life, because support for 3.7 is not being dropped by GitPython (or gitdb) yet, and there is value in keeping GitPython, gitdb, and smmap consistent.

This reverts commit f1b4d14.

Discussion relevant to determining whether this should be merged, as well as whether a new release should be made after doing so if it is, begins at #51 (comment).

Analogous to gitpython-developers/gitdb#94, this brings back Python 3.7 support (allowing it to be installed on 3.7, and testing on 3.7), even though 3.7 is end of life, because support for 3.7 is not being dropped by GitPython (or gitdb) yet, and there is value in keeping GitPython, gitdb, and smmap consistent. This reverts commit f1b4d14.
EliahKagan marked this pull request as ready for review September 17, 2023 08:52
Byron merged commit 156151c into gitpython-developers:master Sep 17, 2023
Copy link
Copy Markdown
Member

Byron commented Sep 17, 2023

Thanks a lot for your help!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.