← 返回首页
No longer treat 3.12 as experimental on CI by EliahKagan · Pull Request #97 · gitpython-developers/gitdb · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

No longer treat 3.12 as experimental on CI#97

Merged
Byron merged 2 commits into
gitpython-developers:masterfrom
EliahKagan:312stable
Oct 3, 2023
Merged

No longer treat 3.12 as experimental on CI#97
Byron merged 2 commits into
gitpython-developers:masterfrom
EliahKagan:312stable

Conversation

Copy link
Copy Markdown
Member

EliahKagan commented Oct 3, 2023
edited
Loading

Python 3.12.0 stable has been released, as well as now being available via setup-python, and these tests have been passing with the release candidate. So this changes the CI test workflow to no longer treat it as experimental. This has two effects:

  • continue-on-error is no longer set to true for 3.12, so 3.12 is no longer special-cased to refrain from cancelling other test jobs when its test job fails. This is the more significant effect.
  • 3.12 can longer be selected as a prerelease. This is the only effect in GitPython, but the less significant of the two effects here and in smmap (GitPython sets fail-fast to false, so one job failing never automatically cancels another job).

With respect to the latter, as well as in a broad conceptual sense, this PR corresponds to gitpython-developers/GitPython#1689.

In addition to those changes, I have also changed this to be triggered the same ways as in GitPython, so that CI test jobs run on all branches. This makes it easier to test changes to CI without, or before, opening a PR. (It also reduces the temptation to use one's fork's default branch for feature development.) However, if you prefer this not be done, I'd be pleased to remove it.

The exactly corresponding PR to this one, in smmap, is gitpython-developers/smmap#54.

This makes it easier to test changes to CI without/before a PR. + Fix a small YAML indentation style inconsistency.
Since Python 3.12.0 stable has been released, as well as now being available via setup-python, per: https://github.com/actions/python-versions/blob/main/versions-manifest.json The main practical effect of this is that continue-on-error is no longer set to true for 3.12, so 3.12 is no longer special-cased to refrain from cancelling other test jobs when its test job fails. Another effect is that 3.12 can longer be selected as a prerelease.
Copy link
Copy Markdown
Member

Byron commented Oct 3, 2023

Thanks a lot, also for making the CI triggers more uniform in respect to GitPython and practical :).

Byron merged commit 256d341 into gitpython-developers:master Oct 3, 2023
EliahKagan deleted the 312stable branch October 3, 2023 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.