← 返回首页
Use actions/checkout feature to fetch all commits by EliahKagan · Pull Request #92 · gitpython-developers/gitdb · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Use actions/checkout feature to fetch all commits#92

Merged
Byron merged 1 commit into
gitpython-developers:masterfrom
EliahKagan:ci-checkout
Sep 11, 2023
Merged

Use actions/checkout feature to fetch all commits#92
Byron merged 1 commit into
gitpython-developers:masterfrom
EliahKagan:ci-checkout

Conversation

Copy link
Copy Markdown
Member

It appears the intent of specifying a fetch-depth of 1000 is that 1000 is greater enough than the current number of commits in the repository that it will fetch the whole branch history, now and for some time into the future.

Assuming that is the case, I recommend doing a full fetch instead, which this PR changes it to do. Setting the fetch-depth to a positive value fetches that many commits back (and the default value is 1), but setting it to 0 fetches all commits, as in a normal deep (full) fetch.

EliahKagan marked this pull request as ready for review September 11, 2023 08:25
Setting the "fetch-depth" to a positive value fetches that many commits back (and the default value is 1), but setting it to 0 fetches all commits, as in a (deep) normal fetch.
Copy link
Copy Markdown
Member

Byron commented Sep 11, 2023

Thank you! I agree that setting it to zero is an indication that we need a couple of commits for tests to work. This reminds me of another glaring issue of GitPython: tests are not isolated and require a certain initial state that affects ones own work-environment. In practice, that's not an issue most of the time, but it's an issue nonetheless. In gitoxide tests are fully isolated and it's as easy as writing a bash script with git commands to setup a new fixture. Maybe one day, GitPython will have isolated/sandboxed tests as well.

Byron merged commit 07948eb into gitpython-developers:master Sep 11, 2023
EliahKagan deleted the ci-checkout branch September 11, 2023 09:21
EliahKagan added a commit to EliahKagan/smmap that referenced this pull request Sep 17, 2023
This updates smmap's CI configuration in ways that are in line with recent updates to gitdb's. In most cases there is no difference in the changes, and the reason for the updates is more to avoid confusing differences than from the value of the changes themselves. In one case, there is a major difference (fetch-depth). - gitpython-developers/gitdb#89 (same) - gitpython-developers/gitdb#90 (same) It's just the project, not dependencies, but otherwise the same. - gitpython-developers/gitdb#92 (opposite) This is the major difference. We don't need more than the tip of the branch in these tests. Keeping the default fetch-depth of 1 by not setting it explicitly avoids giving the impression that the tests here are doing something they are not (and also serves as a speed optimization). - gitpython-developers/gitdb#93 (same)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.