← 返回首页
Never add a vendored smmap directory to sys.path by EliahKagan · Pull Request #102 · gitpython-developers/gitdb · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Never add a vendored smmap directory to sys.path#102

Merged
Byron merged 1 commit into
gitpython-developers:masterfrom
EliahKagan:nopathmod
Oct 20, 2023
Merged

Never add a vendored smmap directory to sys.path#102
Byron merged 1 commit into
gitpython-developers:masterfrom
EliahKagan:nopathmod

Conversation

Copy link
Copy Markdown
Member

EliahKagan commented Oct 20, 2023
edited
Loading

This removes the logic that appended the git submodule directory for smmap to sys.path under most circumstances when the version of gitdb was not from PyPI. Now gitdb does not modify sys.path.

See GitPython#1717 and GitPython#1720 for context. This change is roughly equivalent to the change to GitPython, though as noted the behavior being eliminated is subtly different here and there.

Please note that this does not make any documentation changes (and the changes in #103 are not related to this).

This removes the logic that appended the git submodule directory for smmap to sys.path under most circumstances when the version of gitdb was not from PyPI. Now gitdb does not modify sys.path. See gitpython-developers/GitPython#1717 and gitpython-developers/GitPython#1720 for context. This change is roughly equivalent to the change to GitPython, though as noted the behavior being eliminated is subtly different here and there.
Copy link
Copy Markdown
Member

Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks a lot for tackling this 🙏!

Byron merged commit 9302789 into gitpython-developers:master Oct 20, 2023
EliahKagan deleted the nopathmod branch October 20, 2023 15:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.