← 返回首页
Handle relative `include.path` when root config is provided as a relative path by Copilot · Pull Request #2104 · gitpython-developers/GitPython · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

Handle relative include.path when root config is provided as a relative path#2104

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/test-and-fix-issue-2103
Draft

Handle relative include.path when root config is provided as a relative path#2104
Copilot wants to merge 2 commits into
mainfrom
copilot/test-and-fix-issue-2103

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 25, 2026
edited
Loading

Git config allows relative include paths to be resolved relative to the config file containing the directive. GitPython currently asserts the source config path is absolute during include resolution, which raises AssertionError for valid setups when the parser is initialized with a relative config path.

  • What changed

    • Updated include resolution in GitConfigParser.read() to normalize the current config file path to absolute when needed before resolving relative includes.
    • Removed the absolute-path assertion that caused valid relative-path configurations to fail.
  • Regression coverage

    • Added a focused test in test/test_config.py to verify:
      • main config includes path = b
      • main config is opened via a relative path
      • included values are successfully loaded from b
  • Behavioral impact

    • Relative include semantics now align with git’s documented behavior even when the initial config path passed to GitConfigParser is relative.
    • Existing include cycle/seen-path handling remains unchanged.
# before: could raise AssertionError if main config path is relative with GitConfigParser(os.path.relpath(main_cfg), read_only=True) as cr: cr.get_value("section", "key") # now: relative include in main_cfg resolves correctly

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Byron <63622+Byron@users.noreply.github.com>
Copilot AI changed the title [WIP] Test and fix issue with GitPython functionality Handle relative include.path when root config is provided as a relative path Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.