← 返回首页
fix: add "@firebase/app" as a peerDep in compat packages by hsubox76 · Pull Request #10097 · firebase/firebase-js-sdk · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

fix: add "@firebase/app" as a peerDep in compat packages#10097

Draft
hsubox76 wants to merge 1 commit into
mainfrom
ch-compat-peer-deps
Draft

fix: add "@firebase/app" as a peerDep in compat packages#10097
hsubox76 wants to merge 1 commit into
mainfrom
ch-compat-peer-deps

Conversation

Copy link
Copy Markdown
Contributor

This may fix the issue, or part of the issue, in #3707 where compat packages depend on their underlying modular package, which have a peer dependency on @firebase/app which isn't present in the compat package's package.json. This causes issues with some modern package managers like PNPM and Yarn PNP.

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6644fab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages Name Type
@firebase/installations-compat Patch
@firebase/remote-config-compat Patch
@firebase/performance-compat Patch
@firebase/analytics-compat Patch
@firebase/app-check-compat Patch
@firebase/firestore-compat Patch
@firebase/functions-compat Patch
@firebase/messaging-compat Patch
@firebase/storage-compat Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Code Review

This pull request adds @firebase/app as a peer dependency to several Firebase compatibility packages to resolve dependency issues. The reviewer noted that @firebase/database-compat is missing from this update and should also be included to ensure consistency across all compatibility packages.

'@firebase/functions-compat': patch
'@firebase/messaging-compat': patch
'@firebase/storage-compat': patch
'@firebase/auth-compat': patch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

It appears that @firebase/database-compat is missing from this pull request. Like the other compatibility packages, @firebase/database-compat depends on its underlying modular package (@firebase/database), which has a peer dependency on @firebase/app. To fully resolve the issue for all compat packages (especially for package managers like PNPM and Yarn PnP), please also add @firebase/app as a peer dependency in packages/database-compat/package.json and include it in this changeset.

Suggested change
'@firebase/auth-compat': patch
'@firebase/auth-compat': patch
'@firebase/database-compat': patch

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Footer

© 2026 GitHub, Inc.