chore: Optimize GitHub Actions and release workflows#1207

lahirumaramba

Bumped actions/checkout and actions/setup-java across release.yml, ci.yml, and nightly.yml. This resolves Node.js 20 deprecation warnings and ensures compatibility with Node.js 24+ runners.
Added cache: 'maven' to actions/setup-java across all workflows. This caches precisely ~/.m2/repository, eliminating repetitive 100MB+ downloads from Maven Central and speeding up matrix CI builds.
Configured fetch-depth: 0 and fetch-tags: true on the publish checkout step in release.yml, removing the need for redundant secondary git fetch commands in publish_preflight_check.sh.
Removed the deprecated <gpg.passphrase> property from settings.xml and updated release.yml to pass MAVEN_GPG_PASSPHRASE securely in the runner environment.
Replaced -DskipTests with -Dmaven.test.skip=true in publish_artifacts.sh to completely bypass test compilation and dependency resolution during release artifact deployment.
Replaced the heavy mvn help:evaluate command in publish_preflight_check.sh with a lightweight Python XML parser, making extraction resilient to XML structure changes while reducing execution time from ~12 seconds to milliseconds.

gemini-code-assist

Code Review

This pull request updates the CI/CD workflow by removing the GPG passphrase from the Maven settings, switching to -Dmaven.test.skip=true, and replacing the Maven-based version extraction with a shell command. It also removes several git fetch operations. Reviewers identified that removing the passphrase from settings without passing it as a property to the Maven command will break artifact signing. Additionally, the new grep/sed method for version extraction is considered fragile, and a more robust Python-based XML parsing approach is suggested.

The GPG passphrase was removed from settings.xml, but it is not being passed to the mvn deploy command. The maven-gpg-plugin requires the gpg.passphrase property to sign artifacts in batch mode. Even if MAVEN_GPG_PASSPHRASE is defined in the environment (as noted in the PR description), Maven will not automatically use it. You should explicitly pass it as a property.

Suggested change

      
              -Dmaven.test.skip=true \
          
              -Dmaven.test.skip=true \
          
              -Dgpg.passphrase="${MAVEN_GPG_PASSPHRASE}" \

@gemini-code-assist

@gemini-code-assist This project uses maven-gpg-plugin version 3.2.8. In version 3.x, the plugin natively detects and reads the MAVEN_GPG_PASSPHRASE environment variable during batch execution.

Thank you for the clarification. You are correct that maven-gpg-plugin 3.x and later versions automatically detect the MAVEN_GPG_PASSPHRASE environment variable when running in batch mode. My previous concern regarding the explicit property passing is therefore resolved by your project's use of a modern plugin version.

Is it possible to set the Key ID this way as well?

jonathanedey

LGTM with one comment. Thanks!

Is it possible to set the Key ID this way as well?

chore: Optimize GitHub Actions and release workflows

7bc135a

lahirumaramba added the release:stage Stage a release candidate label May 15, 2026

gemini-code-assist Bot reviewed May 15, 2026

View reviewed changes

update actions commit hashes

dc300e6

lahirumaramba requested a review from jonathanedey May 15, 2026 19:55

Optimize pom.xml version extraction in preflight check using robust P… …

5b432f3

…ython XML parsing

jonathanedey approved these changes May 19, 2026

View reviewed changes

               mvn -B clean deploy \
                 -Dcheckstyle.skip \
-                -DskipTests \
+                -Dmaven.test.skip=true \

               mvn -B clean deploy \
                 -Dcheckstyle.skip \
-                -DskipTests \
+                -Dmaven.test.skip=true \

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Optimize GitHub Actions and release workflows#1207