← 返回首页
Add equals() and hashCode() to CreateRequest by Nagajyothi-tammisetti · Pull Request #1197 · firebase/firebase-admin-java · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Add equals() and hashCode() to CreateRequest#1197

Open
Nagajyothi-tammisetti wants to merge 2 commits into
firebase:mainfrom
Nagajyothi-tammisetti:patch-1
Open

Add equals() and hashCode() to CreateRequest#1197
Nagajyothi-tammisetti wants to merge 2 commits into
firebase:mainfrom
Nagajyothi-tammisetti:patch-1

Conversation

Nagajyothi-tammisetti commented Mar 13, 2026

Copy link
Copy Markdown

This PR adds equals() and hashCode() implementations to the CreateRequest class in UserRecord.

This allows proper comparison between CreateRequest objects and resolves the issue where CreateRequest did not override equals().

Implements equals() and hashCode() for the CreateRequest class to allow proper object comparison.

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

Add equals() and hashCode() to CreateRequest …
cf7134b
Implements equals() and hashCode() for the CreateRequest class to allow proper object comparison.

gemini-code-assist Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the CreateRequest class by adding standard equals() and hashCode() implementations. This change enables accurate value-based comparison between CreateRequest objects, which is essential for their correct behavior in collections and other scenarios requiring object equality checks.

Highlights

  • CreateRequest Object Comparison: Implemented equals() and hashCode() methods in the CreateRequest inner class within UserRecord.java to ensure proper object comparison.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/google/firebase/auth/UserRecord.java
    • Added equals() method to the CreateRequest inner class.
    • Added hashCode() method to the CreateRequest inner class.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist Bot reviewed Mar 13, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Code Review

This pull request adds equals() and hashCode() to UserRecord.CreateRequest. The implementation is sound, but the equals method can be made more robust. I've suggested using a getClass() check instead of instanceof to ensure the symmetry contract is upheld, which is a best practice for non-final classes.

Comment thread src/main/java/com/google/firebase/auth/UserRecord.java Show resolved Hide resolved

Nagajyothi-tammisetti commented Mar 13, 2026

Copy link
Copy Markdown
Author

Hi! I have implemented equals() and hashCode() for the CreateRequest class.
Please let me know if any changes are needed. Thank you for reviewing!

Nagajyothi-tammisetti commented Mar 14, 2026

Copy link
Copy Markdown
Author

Hi maintainers,
I have implemented the requested changes and the CLA check has passed.
Could you please review the PR when convenient?

Thank you!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Footer

© 2026 GitHub, Inc.