← 返回首页
feat: Add `divide` icons by csandman · Pull Request #568 · feathericons/feather · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

feat: Add divide icons#568

Merged
colebemis merged 3 commits into
feathericons:masterfrom
csandman:add-division-icons
Apr 4, 2020
Merged

feat: Add divide icons#568
colebemis merged 3 commits into
feathericons:masterfrom
csandman:add-division-icons

Conversation

csandman commented Apr 2, 2019

Copy link
Copy Markdown
Contributor

Added 3 division icons (also knows as an obelus). One by itself, one with a circle around it, and one with a square around it. These are meant to compliment the plus, minus, and x icons and fill out the set of math icons.

The shapes are composed the same way as they are in the other math icons, using 1px lines for the points.

Closes #263

feat: Add divide icons …
e92abf3
Added 3 division icons (also knows as an obelus). One by itself, one with a circle around it, and one with a square around it. These are meant to compliment plus, minus, and x icons.

codecov Bot commented Apr 2, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #568 into master will not change coverage by %.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #568 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 34 34 Branches 3 3 ========================================= Hits 34 34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca4f12...a29060e. Read the comment docs.

moeenio mentioned this pull request Apr 2, 2019
Closed

colebemis commented Jun 5, 2019

Copy link
Copy Markdown
Member

@csandman These look great! Thanks for opening a PR 🎉

My only feedback is that the dots on the divide icon might be a little small relative to the rest of the icon:

Could you try a version that uses a larger circle similar to the percent icon?

csandman commented Jul 11, 2019

Copy link
Copy Markdown
Contributor Author

@colebemis Sorry I saw your comment so late! I gave it a shot, is this what you were thinking of?

The main reason I avoided this is because I felt that the circles were a bit too large but its up to you.

mittalyashu commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

@csandman If you zoom out the divide icon looks perfect with bigger dots.

ElForastero commented Feb 29, 2020 •
edited
Loading

Copy link
Copy Markdown

Yeah, it looks a little bit thin compared to other icons.

But I still love it 😉

csandman commented Mar 3, 2020

Copy link
Copy Markdown
Contributor Author

I know this is rather old, but I never pushed my change with the change requested by @colebemis

Anyway, now I have so feel free to merge if you like the change!

Here is what all 3 icons look like in context of the other icons:

colebemis approved these changes Apr 4, 2020
View reviewed changes

colebemis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Thanks, @csandman! ❤️

colebemis merged commit 9e0dcca into feathericons:master Apr 4, 2020
snyk-bot mentioned this pull request Apr 7, 2020
Merged
dgdavid mentioned this pull request Apr 21, 2020
Open
csandman deleted the add-division-icons branch April 27, 2020 16:19
valdisiljuconoks mentioned this pull request May 22, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

colebemis colebemis approved these changes
+1 more reviewer
FirstLast94397 FirstLast94397 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Icon Request: divide

5 participants

Footer

© 2026 GitHub, Inc.