← 返回首页
Fix column name and add Streamlit app for loan applications by danchev · Pull Request #20 · feast-dev/feast-credit-score-local-tutorial · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Fix column name and add Streamlit app for loan applications#20

Open
danchev wants to merge 2 commits into
feast-dev:mainfrom
danchev:main
Open

Fix column name and add Streamlit app for loan applications#20
danchev wants to merge 2 commits into
feast-dev:mainfrom
danchev:main

Conversation

danchev commented Nov 17, 2025

Copy link
Copy Markdown

Key changes include:

  • Corrected the column name in the training feature selection for proper data handling.

  • Introduced a new Streamlit application for interactive loan applications using the trained credit scoring model.

  • Updated README with instructions for running the Streamlit app and added a demo image.

  • Enhanced pyproject.toml to include Streamlit as an optional dependency.

Copilot AI review requested due to automatic review settings November 17, 2025 02:52
Copilot AI reviewed Nov 17, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Pull Request Overview

This PR fixes a column name typo in the training feature selection and introduces a new Streamlit application for interactive loan applications.

  • Fixed column name from created_timestamp to created_timestamp__ in training feature selection
  • Added a Streamlit web application for interactive loan application demo
  • Updated dependencies to include Streamlit, SHAP, and matplotlib as optional extras

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file File Description
credit_model.py Fixed column name in training feature selection (typo correction)
streamlit_app.py New Streamlit application for interactive loan applications using the trained model
pyproject.toml Added optional Streamlit dependencies group with streamlit, shap, and matplotlib
README.md Updated documentation with Streamlit app usage instructions and demo image
uv.lock Updated lock file to include new dependencies for Streamlit functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread streamlit_app.py Show resolved Hide resolved
Comment thread credit_model.py Show resolved Hide resolved
Comment thread streamlit_app.py Outdated Show resolved Hide resolved
feat: Add Streamlit app for interactive loan applications …
d814581
- Introduced a new Streamlit application to facilitate interactive loan applications using the trained credit scoring model. - Updated README to include instructions for running the Streamlit app and added a demo image. - Enhanced pyproject.toml to include Streamlit as an optional dependency. This addition allows users to visualize and interact with the credit scoring model in a user-friendly manner. Signed-off-by: D. Danchev <12420863+danchev@users.noreply.github.com>
fix: Correct column name in training feature selection …
04be06c
- Updated the column name from "created_timestamp" to "created_timestamp__" to ensure proper feature extraction during model training. Signed-off-by: D. Danchev <12420863+danchev@users.noreply.github.com>
shuchu approved these changes Nov 17, 2025
View reviewed changes

shuchu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

lgtm

danchev commented Dec 2, 2025

Copy link
Copy Markdown
Author

@shuchu Are you able to merge this, or is there anything else needed before we can close it?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
shuchu shuchu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.