fix: Fix SparkRetrievalJob.persist() failing for SparkSource by ntkathole · Pull Request #6410 · feast-dev/feast · GitHub
Conversation
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Footer
You can’t perform that action at this time.
What this PR does / why we need it:
Fixes #6261
SparkRetrievalJob.persist() failed in two scenarios:
Remote offline store path: When using type: remote in feature_store.yaml pointing to a Spark offline server, the server calls SavedDatasetStorage.from_data_source(data_source) to convert the registered SparkSource into storage. This raised ValueError because SparkSource was not registered in the _DATA_SOURCE_TO_SAVED_DATASET_STORAGE mapping, and SavedDatasetSparkStorage lacked a from_data_source() method.
Path-based SparkSource: When using a path-based SparkSource (e.g., S3 with parquet), persist() required a table name and raised ValueError if one wasn't provided, even though the storage had a valid path configured.