← 返回首页
feat: Bump redis-py version cap from <5 to <8 by neolunar7 · Pull Request #6339 · feast-dev/feast · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

feat: Bump redis-py version cap from <5 to <8#6339

Merged
ntkathole merged 2 commits into
feast-dev:masterfrom
neolunar7:bump-redis-py-version-cap
May 1, 2026
Merged

feat: Bump redis-py version cap from <5 to <8#6339
ntkathole merged 2 commits into
feast-dev:masterfrom
neolunar7:bump-redis-py-version-cap

Conversation

Copy link
Copy Markdown
Contributor

neolunar7 commented Apr 27, 2026 •
edited by devin-ai-integration Bot
Loading

Summary

  • Bumps redis dependency from >=4.2.2,<5 to >=4.2.2,<8
  • Bumps hiredis dependency from >=2.0.0,<3 to >=2.0.0,<4

Motivation

The current redis<5 pin prevents downstream servers that depend on Feast from using redis-py 5+. Since redis-py is now at version 7.4.0, this is an increasingly painful constraint for users who need newer redis-py features or have other dependencies requiring redis-py 5+.

Compatibility Analysis

Feast uses only one file that imports redis (sdk/python/feast/infra/online_stores/redis.py). The APIs used are all stable across v4 through v7:

  • Redis, RedisCluster, Sentinel client classes
  • redis.asyncio module (Redis, RedisCluster, Sentinel)
  • pipeline(), hset(), hmget(), hgetall(), scan_iter(), delete(), hdel(), expire()

All imports and method signatures are unchanged from redis-py 4.x to 7.x.

The hiredis cap is bumped from <3 to <4 because redis-py 5+ requires hiredis>=3.0 when the hiredis extra is used.

Test plan

  • Verified all redis imports work with redis-py 7.4.0
  • Verified all redis API methods used by Feast exist and are compatible
  • All 19 redis unit tests pass with redis-py 7.4.0 (1 test errored due to unrelated missing dask dep in test fixture)

devin-ai-integration Bot reviewed Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Copy link
Copy Markdown
Member

ntkathole commented Apr 28, 2026

@neolunar7 can you also run make lock-python-dependencies-all to update requirements and make sure this bump doesn't break anything?

neolunar7 requested a review from a team as a code owner April 29, 2026 11:34
feat: Bump redis-py version cap from <5 to <8 …
3377790
The redis-py dependency was pinned to <5, which prevented downstream servers using Feast from upgrading to redis-py 5+. The redis-py APIs used by Feast (Redis, RedisCluster, Sentinel, pipeline, hset, hmget, hgetall, scan_iter, delete, hdel, expire) are fully compatible across v4 through v7. Also bumps hiredis cap from <3 to <4 since redis-py 5+ requires hiredis>=3.0 when the hiredis extra is used. Signed-off-by: neolunar7 <piljae@rapportlabs.kr> Signed-off-by: neolunar7 <neolunar7@gmail.com>
neolunar7 force-pushed the bump-redis-py-version-cap branch from efbb4ac to 1b4e643 Compare May 1, 2026 06:56
Copy link
Copy Markdown
Contributor Author

neolunar7 commented May 1, 2026

@ntkathole I've added the relevant files too, thanks :)

Copy link
Copy Markdown
Member

ntkathole commented May 1, 2026

@neolunar7 looks like pixi.lock file also need to update

chore: Regenerate requirements lock files for redis bump …
b336ae5
Signed-off-by: neolunar7 <neolunar7@gmail.com>
neolunar7 force-pushed the bump-redis-py-version-cap branch from 1b4e643 to b336ae5 Compare May 1, 2026 07:29
Hide details View details ntkathole merged commit 9538180 into feast-dev:master May 1, 2026
25 of 26 checks passed
franciscojavierarceo pushed a commit that referenced this pull request May 4, 2026
chore(release): release 0.63.0 …
50ad181
# [0.63.0](v0.62.0...v0.63.0) (2026-05-04) ### Bug Fixes * Add project filter to apply_data_source and delete_data_source (closes [#6206](#6206)) ([#6322](#6322)) ([96562c4](96562c4)) * Add project_id filter to SnowflakeRegistry UPDATE path ([#6243](#6243)) ([6658b71](6658b71)), closes [#6208](#6208) [#6208](#6208) * Add subprocess timeouts to prevent test_e2e_local hanging on Dask atexit handler ([3de6556](3de6556)) * Ambiguous truth value of array during materialization ([#6259](#6259)) ([d0c8984](d0c8984)) * Auto-detect GCS/S3 registry store when registry is passed as string ([#6260](#6260)) ([7ebcf03](7ebcf03)) * **bigquery:** Prefer query over table in get_table_query_string ([#6360](#6360)) ([77ed779](77ed779)), closes [#6200](#6200) * correct project_id scoping in get_user_metadata and delete_project ([0c469a7](0c469a7)) * disable Redis RDB persistence in test deployments ([44cd682](44cd682)) * Disable snowflake tests temporarily in CI ([#6356](#6356)) ([31d5a98](31d5a98)) * Filter empty SQL commands at execute_snowflake_statement call sites ([#6249](#6249)) ([92ffbb9](92ffbb9)) * Fix five bugs in milvus online store ([#6275](#6275)) ([212504b](212504b)) * Fix issue with apply feature view ([835cda8](835cda8)) * Fix streaming materialization for exotic sources with lazy UDF pipelines ([c07972d](c07972d)) * Handle missing features gracefully instead of panicking ([7d00b3a](7d00b3a)) * Harden informer cache with label selectors and memory optimizations ([#6242](#6242)) ([3f11356](3f11356)) * **helm:** Avoid nil pointer for metrics.enabled inside podAnnotations ([#6251](#6251)) ([c833f1a](c833f1a)) * Include git in feast server image ([fb03c46](fb03c46)) * Include StreamFeatureView in freshness metric ([#6269](#6269)) ([463f16c](463f16c)) * Pre-create S3A event log dir before SparkContext init ([#6317](#6317)) ([9feca77](9feca77)) * Remote Online Store Type Inference Error with All-NULL Columns ([#6063](#6063)) ([de67bdd](de67bdd)) * Remove selector with kustomize overlay using a JSON 6902 patch ([9107a43](9107a43)) * Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling ([#6315](#6315)) ([7e66a2e](7e66a2e)) * **spark:** BatchFeatureView with TransformationMode.PYTHON now reads all source columns ([a310eaf](a310eaf)) * **spark:** Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query ([e1b1d2d](e1b1d2d)) * Support pandas mode in feature builder and fix dask column extraction ([863315e](863315e)) * support SQL string as entity_df in RemoteOfflineStore.get_historical_features ([c559889](c559889)) * Wrap LocalOutputNode return value in ArrowTableValue for consist… ([#6286](#6286)) ([a16cd55](a16cd55)) ### Features * Add agent skills and Cursor/Claude rules for Feast development ([312eea3](312eea3)) * Add feature view versioning support to FAISS online store ([b36acb7](b36acb7)) * Add feature view versioning support to Redis and DynamoDB online stores ([#6257](#6257)) ([edf25af](edf25af)), closes [#6164](#6164) [#6163](#6163) * Add optional 'org' in feature view ([#6288](#6288)) ([#6301](#6301)) ([608b105](608b105)) * Add RaySource, to_ray_dataset first-class method, docs, and tests ([1c98157](1c98157)) * Add TLS support for Go Feature Server ([#6229](#6229)) ([28a58d0](28a58d0)) * Add Vector Search support to MongoDBOnlineStore ([#6344](#6344)) ([c102738](c102738)) * Add versioning support to Milvus online store ([#6330](#6330)) ([3268ced](3268ced)) * Addresses performance issues in the Redis online store ([2e50da0](2e50da0)) * Allow to set gpu for ray ([5580ab4](5580ab4)) * Bump redis-py version cap from <5 to <8 ([#6339](#6339)) ([9538180](9538180)) * Expose feature_server, materialization, and openlineage configuration via FeatureStore CRD ([ec6ecfd](ec6ecfd)) * Make online_write_batch_size configurable in MaterializationConfig ([#6268](#6268)) ([d41becf](d41becf)) * Make udf optional if agg defined ([#5689](#5689)) ([#6328](#6328)) ([f630056](f630056)) * MongoDB offline store ([#6138](#6138)) ([8eebad7](8eebad7)) * Optional input_schema for ODFV ([#6308](#6308)) ([#6312](#6312)) ([f08b4e8](f08b4e8)) * Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser ([#6240](#6240)) ([dca57e8](dca57e8)) * **spark:** Add compute-on-read support for BatchFeatureView in get_… ([#6357](#6357)) ([630d9f8](630d9f8))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

devin-ai-integration[bot] devin-ai-integration[bot] left review comments

ntkathole ntkathole approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.