← 返回首页
fix: Date wise remote offline store historical data retrieval by aniketpalu · Pull Request #5686 · feast-dev/feast · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

fix: Date wise remote offline store historical data retrieval #5686

Merged
ntkathole merged 2 commits into
feast-dev:masterfrom
aniketpalu:RHOAIENG-32904
Oct 23, 2025
Merged

fix: Date wise remote offline store historical data retrieval #5686
ntkathole merged 2 commits into
feast-dev:masterfrom
aniketpalu:RHOAIENG-32904

Conversation

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

When using a remote offline store with PostgreSQL backend, calling get_historical_features() with start_date and end_date parameters fails with:

TypeError: Got an unexpected keyword argument 'start_date' / 'end_date' for RemoteOfflineStore

The implementation follows the same pattern used by local PostgreSQL based offline stores ensuring consistency across the codebase:

  • Client-side changes (remote.py):

    • Add **kwargs parameter to RemoteOfflineStore.get_historical_features() method signature
    • Extract start_date and end_date from kwargs and serialize them to ISO format strings
    • Include serialized dates in api_parameters for transmission over Arrow Flight
  • Server-side changes (offline_server.py):

    • Extract start_date and end_date from the command dict (if present)
    • Deserialize ISO format strings back to timezone-aware datetime objects
    • Pass extracted dates as **kwargs to the underlying offline store

Which issue(s) this PR fixes:

Misc

aniketpalu requested a review from a team as a code owner October 21, 2025 12:22
Copy link
Copy Markdown
Member

ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

lgtm

…RemoteOfflineStore Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
Hide details View details ntkathole merged commit 949ba3d into feast-dev:master Oct 23, 2025
17 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Oct 27, 2025
# [0.56.0](v0.55.0...v0.56.0) (2025-10-27) ### Bug Fixes * Add mode field to Transformation proto for proper serialization ([2390d2e](2390d2e)) * Date wise remote offline store historical data retrieval ([#5686](#5686)) ([949ba3d](949ba3d)) * Fix STRING type handling in on-demand feature views ([#5669](#5669)) ([dfbb743](dfbb743)) * Fixed torch install issue in CI ([366e5a8](366e5a8)) * ODFV not getting counted in resource count ([1d640b6](1d640b6)) * Skip tag updates if user do not have permissions ([#5673](#5673)) ([0a951ce](0a951ce)) ### Features * Add document of Go feature server. ([#5697](#5697)) ([cbd1dde](cbd1dde)) * Add flexible commandArgs support for complete Feast CLI control ([#5678](#5678)) ([6414924](6414924)) * Add HDFS as a feature registry ([#5655](#5655)) ([4c65872](4c65872)) * Add nodeSelector to service config ([#5675](#5675)) ([9728cde](9728cde)) * Add OTEL based observability to the Go Feature Server ([#5685](#5685)) ([f4afdad](f4afdad)) * Added health endpoint for the UI ([#5665](#5665)) ([3aec5d5](3aec5d5)) * Added kuberay support ([e0b698d](e0b698d)) * Added support for filtering multi-projects ([#5688](#5688)) ([eb0a86e](eb0a86e)) * Batch Embedding at scale for RAG with Ray ([cc2a46d](cc2a46d)) * Optimize SQL entity handling without creating temporary tables ([#5695](#5695)) ([aa2c838](aa2c838)) * Support aggregation in odfv ([#5666](#5666)) ([564e965](564e965)) * Support cache_mode for registries ([021e9ea](021e9ea))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.