← 返回首页
feat: Add nodeSelector to service config by blaketastic2 · Pull Request #5675 · feast-dev/feast · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

feat: Add nodeSelector to service config#5675

Merged
franciscojavierarceo merged 7 commits into
feast-dev:masterfrom
blaketastic2:blake/node-selectors
Oct 21, 2025
Merged

feat: Add nodeSelector to service config#5675
franciscojavierarceo merged 7 commits into
feast-dev:masterfrom
blaketastic2:blake/node-selectors

Conversation

Copy link
Copy Markdown
Contributor

blaketastic2 commented Oct 16, 2025

What this PR does / why we need it:

This allows us to set nodeSelectors on the services in the operator, allowing greater deployment control.

Which issue(s) this PR fixes:

None

Misc

None

add NodeSelector support to config …
82475a3
Signed-off-by: Blake <blaketastic2@gmail.com>
blaketastic2 requested a review from a team as a code owner October 16, 2025 20:35
Copilot AI reviewed Oct 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Pull Request Overview

This PR adds support for configuring nodeSelector on Feast service deployments within the Kubernetes operator, enabling users to control pod placement on specific nodes.

Key Changes:

  • Added nodeSelector field to OptionalCtrConfigs struct in the API
  • Implemented logic to apply node selectors to pod specifications
  • Added comprehensive test coverage for node selector behavior

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file File Description
api/v1alpha1/featurestore_types.go Added NodeSelector field to OptionalCtrConfigs struct
api/v1alpha1/zz_generated.deepcopy.go Generated deep copy logic for the new NodeSelector field
config/crd/bases/feast.dev_featurestores.yaml Updated CRD schema to include nodeSelector field definitions
docs/api/markdown/ref.md Updated API documentation to reflect new nodeSelector field
internal/controller/services/services.go Implemented node selector retrieval and application logic
internal/controller/services/services_test.go Added comprehensive test cases for node selector functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved
Comment thread infra/feast-operator/docs/api/markdown/ref.md Show resolved Hide resolved
code review updates …
621ffea
Signed-off-by: Blake <blaketastic2@gmail.com>
contrived example was actually wrong …
6a07950
Signed-off-by: Blake <blaketastic2@gmail.com>
removing incorrect docs …
4ab65ff
Signed-off-by: Blake <blaketastic2@gmail.com>
docs are not working with description …
4fb5c8d
Signed-off-by: Blake <blaketastic2@gmail.com>
Hide details View details franciscojavierarceo merged commit 9728cde into feast-dev:master Oct 21, 2025
20 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Oct 27, 2025
chore(release): release 0.56.0 …
90b5086
# [0.56.0](v0.55.0...v0.56.0) (2025-10-27) ### Bug Fixes * Add mode field to Transformation proto for proper serialization ([2390d2e](2390d2e)) * Date wise remote offline store historical data retrieval ([#5686](#5686)) ([949ba3d](949ba3d)) * Fix STRING type handling in on-demand feature views ([#5669](#5669)) ([dfbb743](dfbb743)) * Fixed torch install issue in CI ([366e5a8](366e5a8)) * ODFV not getting counted in resource count ([1d640b6](1d640b6)) * Skip tag updates if user do not have permissions ([#5673](#5673)) ([0a951ce](0a951ce)) ### Features * Add document of Go feature server. ([#5697](#5697)) ([cbd1dde](cbd1dde)) * Add flexible commandArgs support for complete Feast CLI control ([#5678](#5678)) ([6414924](6414924)) * Add HDFS as a feature registry ([#5655](#5655)) ([4c65872](4c65872)) * Add nodeSelector to service config ([#5675](#5675)) ([9728cde](9728cde)) * Add OTEL based observability to the Go Feature Server ([#5685](#5685)) ([f4afdad](f4afdad)) * Added health endpoint for the UI ([#5665](#5665)) ([3aec5d5](3aec5d5)) * Added kuberay support ([e0b698d](e0b698d)) * Added support for filtering multi-projects ([#5688](#5688)) ([eb0a86e](eb0a86e)) * Batch Embedding at scale for RAG with Ray ([cc2a46d](cc2a46d)) * Optimize SQL entity handling without creating temporary tables ([#5695](#5695)) ([aa2c838](aa2c838)) * Support aggregation in odfv ([#5666](#5666)) ([564e965](564e965)) * Support cache_mode for registries ([021e9ea](021e9ea))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

tchughesiv

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.