← 返回首页
fix: Normalize current version by removing 'v' prefix if present by ntkathole · Pull Request #5500 · feast-dev/feast · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

fix: Normalize current version by removing 'v' prefix if present#5500

Merged
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
ntkathole:inconsistency_versions
Jul 12, 2025
Merged

fix: Normalize current version by removing 'v' prefix if present#5500
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
ntkathole:inconsistency_versions

Conversation

Copy link
Copy Markdown
Member

ntkathole commented Jul 9, 2025 •
edited
Loading

What this PR does / why we need it:

When custom version not provided:

The release workflow (https://github.com/feast-dev/feast/blob/master/.github/workflows/release.yml#L83) will already bump all file versions (including ui/package.json) during validation.
The UI workflow should just use whatever version is already in the files.

  1. release.yml runs:
    ├── bump_file_versions.py updates ui/package.json
    ├── Creates v0.50.0 tag
    └── Commits changes
  2. Tag push triggers publish.yml:
    ├── ui/package.json already has 0.50.0
    └── publish_web_ui.yml uses correct version

When custom version provided:
Normalize custom version (next version) by removing 'v' prefix if present. Get current version as last released tag without 'v' prefix .

ntkathole self-assigned this Jul 9, 2025
ntkathole marked this pull request as draft July 9, 2025 14:50
ntkathole force-pushed the inconsistency_versions branch from 8e129cd to 0786af1 Compare July 9, 2025 15:03
ntkathole changed the title fix: Fix release version without prefix fix: UI publish workflow should just use whatever version is already in the files Jul 9, 2025
ntkathole marked this pull request as ready for review July 9, 2025 15:07
franciscojavierarceo reviewed Jul 10, 2025
View reviewed changes
Comment thread .github/workflows/publish.yml
needs: [ publish-python-sdk ]
secrets: inherit
with:
custom_version: ${{ github.event.inputs.custom_version }}
Copy link
Copy Markdown
Member

franciscojavierarceo Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

sometimes we have to override the custom version for historical issues.

ntkathole force-pushed the inconsistency_versions branch from 0786af1 to 9112e46 Compare July 12, 2025 10:45
ntkathole changed the title fix: UI publish workflow should just use whatever version is already in the files fix: Normalize current version by removing 'v' prefix if present Jul 12, 2025
fix: Fix release version without prefix …
6f92c19
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
ntkathole force-pushed the inconsistency_versions branch from 9112e46 to 6f92c19 Compare July 12, 2025 10:59
Hide details View details franciscojavierarceo merged commit 43f3d52 into feast-dev:master Jul 12, 2025
17 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Jul 21, 2025
chore(release): release 0.51.0 …
8f6555f
# [0.51.0](v0.50.0...v0.51.0) (2025-07-21) ### Bug Fixes * FeatureView serialization with cycle detection ([#5502](#5502)) ([f287ca5](f287ca5)) * Fix current version in publish workflow ([#5499](#5499)) ([0af6e94](0af6e94)) * Fix NPM authentication ([#5506](#5506)) ([9f85892](9f85892)) * Fix verify wheels workflow for macos14 ([#5486](#5486)) ([07174cc](07174cc)) * Fixed error thrown for invalid project name on features api ([#5525](#5525)) ([4a9a5d0](4a9a5d0)) * Fixed ODFV on-write transformations ([271ef74](271ef74)) * Move Install OS X dependencies before python setup ([#5488](#5488)) ([35f211c](35f211c)) * Normalize current version by removing 'v' prefix if present ([#5500](#5500)) ([43f3d52](43f3d52)) * Skip macOS 14 with Python 3.10 due to gettext library ([#5490](#5490)) ([41d4977](41d4977)) * Standalone Web UI Publish Workflow ([#5498](#5498)) ([c47b134](c47b134)) ### Features * Added endpoints to allow user to get data for all projects ([4e06965](4e06965)) * Added grpc and rest endpoint for features ([#5519](#5519)) ([0a75696](0a75696)) * Added relationship support to all API endpoints ([#5496](#5496)) ([bea83e7](bea83e7)) * Continue updating doc ([#5523](#5523)) ([ea53b2b](ea53b2b)) * Hybrid offline store ([#5510](#5510)) ([8f1af55](8f1af55)) * Populate created and updated timestamp on data sources ([af3056b](af3056b)) * Provide ready-to-use Python definitions in api ([37628d9](37628d9)) * Snowflake source. fetch MAX in a single query ([#5387](#5387)) ([b49cea1](b49cea1)) * Support compute engine to use multi feature views as source ([#5482](#5482)) ([b9ac90b](b9ac90b)) * Support pagination and sorting on registry apis ([#5495](#5495)) ([c4b6fbe](c4b6fbe)) * Update doc ([#5521](#5521)) ([2808ce1](2808ce1))
HaoXuAI pushed a commit that referenced this pull request Aug 11, 2025
chore(release): release 0.51.0 …
52cd921
# [0.51.0](v0.50.0...v0.51.0) (2025-07-21) ### Bug Fixes * FeatureView serialization with cycle detection ([#5502](#5502)) ([f287ca5](f287ca5)) * Fix current version in publish workflow ([#5499](#5499)) ([0af6e94](0af6e94)) * Fix NPM authentication ([#5506](#5506)) ([9f85892](9f85892)) * Fix verify wheels workflow for macos14 ([#5486](#5486)) ([07174cc](07174cc)) * Fixed error thrown for invalid project name on features api ([#5525](#5525)) ([4a9a5d0](4a9a5d0)) * Fixed ODFV on-write transformations ([271ef74](271ef74)) * Move Install OS X dependencies before python setup ([#5488](#5488)) ([35f211c](35f211c)) * Normalize current version by removing 'v' prefix if present ([#5500](#5500)) ([43f3d52](43f3d52)) * Skip macOS 14 with Python 3.10 due to gettext library ([#5490](#5490)) ([41d4977](41d4977)) * Standalone Web UI Publish Workflow ([#5498](#5498)) ([c47b134](c47b134)) ### Features * Added endpoints to allow user to get data for all projects ([4e06965](4e06965)) * Added grpc and rest endpoint for features ([#5519](#5519)) ([0a75696](0a75696)) * Added relationship support to all API endpoints ([#5496](#5496)) ([bea83e7](bea83e7)) * Continue updating doc ([#5523](#5523)) ([ea53b2b](ea53b2b)) * Hybrid offline store ([#5510](#5510)) ([8f1af55](8f1af55)) * Populate created and updated timestamp on data sources ([af3056b](af3056b)) * Provide ready-to-use Python definitions in api ([37628d9](37628d9)) * Snowflake source. fetch MAX in a single query ([#5387](#5387)) ([b49cea1](b49cea1)) * Support compute engine to use multi feature views as source ([#5482](#5482)) ([b9ac90b](b9ac90b)) * Support pagination and sorting on registry apis ([#5495](#5495)) ([c4b6fbe](c4b6fbe)) * Update doc ([#5521](#5521)) ([2808ce1](2808ce1))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

franciscojavierarceo franciscojavierarceo approved these changes

Assignees

ntkathole

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.