← 返回首页
fix: Changed Env Vars for e2e tests by tmihalac · Pull Request #4975 · feast-dev/feast · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

fix: Changed Env Vars for e2e tests#4975

Merged
tchughesiv merged 2 commits into
feast-dev:masterfrom
opendatahub-io:master
Jan 29, 2025
Merged

fix: Changed Env Vars for e2e tests#4975
tchughesiv merged 2 commits into
feast-dev:masterfrom
opendatahub-io:master

Conversation

Copy link
Copy Markdown
Contributor

Added conditional run of BeforeAll in e2e tests, after the change it will not run in an OpeshiftCI environment since the OpeshiftCI infrastructure is responsible for the operations performed in BeforeAll

What this PR does / why we need it:

This change is need to enable e2e tests to be run with OpenshiftCI

Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
tmihalac requested a review from a team as a code owner January 28, 2025 15:41
tmihalac changed the title Changed Env Vars for e2e tests Fix: Changed Env Vars for e2e tests Jan 28, 2025
tmihalac changed the title Fix: Changed Env Vars for e2e tests fix: Changed Env Vars for e2e tests Jan 28, 2025
Comment thread infra/feast-operator/test/e2e/e2e_test.go Outdated Show resolved Hide resolved
Comment thread infra/feast-operator/test/e2e/e2e_test.go Outdated Show resolved Hide resolved
Comment thread infra/feast-operator/test/e2e/e2e_test.go Outdated Show resolved Hide resolved
Comment thread infra/feast-operator/test/e2e/e2e_test.go Outdated Show resolved Hide resolved
Comment thread infra/feast-operator/test/e2e/e2e_test.go Show resolved Hide resolved
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
redhatHameed added the go Pull requests that update Go code label Jan 29, 2025
tchughesiv added go Pull requests that update Go code and removed go Pull requests that update Go code labels Jan 29, 2025
Copy link
Copy Markdown
Contributor

tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

lgtm

tchughesiv enabled auto-merge (squash) January 29, 2025 15:23
redhatHameed removed the go Pull requests that update Go code label Jan 29, 2025
Copy link
Copy Markdown
Member

hmmm, wonder why the tests aren't running

tchughesiv merged commit fa0084f into feast-dev:master Jan 29, 2025
Copy link
Copy Markdown
Contributor

@franciscojavierarceo I added the "go" label, expecting it to run all related Go code changes, including operator tests but it skipped tests like the operator e2e tests so I think we need adjust this label to include operator related test and exclude irrelevant tests.

tchughesiv pushed a commit to tchughesiv/feast that referenced this pull request Jan 30, 2025
* Changed Env Vars for e2e tests Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Made e2e changes following review Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> --------- Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
tchughesiv pushed a commit to tchughesiv/feast that referenced this pull request Jan 30, 2025
* Changed Env Vars for e2e tests Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> * Made e2e changes following review Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> --------- Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> Signed-off-by: Tommy Hughes <tohughes@redhat.com>
tchughesiv added a commit that referenced this pull request Jan 30, 2025
* Changed Env Vars for e2e tests * Made e2e changes following review --------- Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> Signed-off-by: Tommy Hughes <tohughes@redhat.com> Co-authored-by: Theodor Mihalache <84387487+tmihalac@users.noreply.github.com>
franciscojavierarceo pushed a commit that referenced this pull request Feb 4, 2025
# [0.44.0](v0.43.0...v0.44.0) (2025-02-04) ### Bug Fixes * Adding periodic check to fix the sporadic failures of the operator e2e tests. ([#4952](#4952)) ([1d086be](1d086be)) * Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee)) * Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f)) * Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962) * Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85)) * Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d)) * Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939)) * Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9)) * Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52)) * Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703)) * Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3)) * Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102)) * Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68)) * Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55)) ### Features * Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8)) * Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852)) * Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d)) * Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3)) * Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc)) * Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13)) * Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364)) * Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c)) * Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Footer

© 2026 GitHub, Inc.