← 返回首页
fix: Fix showing selected navigation item in UI sidebar by peruukki · Pull Request #4969 · feast-dev/feast · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

fix: Fix showing selected navigation item in UI sidebar#4969

Merged
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
peruukki:ui-fix-showing-selected-sidebar-item
Jan 26, 2025
Merged

fix: Fix showing selected navigation item in UI sidebar#4969
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
peruukki:ui-fix-showing-selected-sidebar-item

Conversation

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Fixes showing the currently active/selected navigation item in the sidebar.

Before

After

Which issue(s) this PR fixes:

No related issues as far as I know, just something I happened to notice.

Misc

Our useMatchSubpath hook uses these two react-router-dom hooks:

  1. useResolvedPath
  2. useMatch

After some investigation, I found that useMatch doesn't work with relative or partial paths. Furthermore, in our Sidebar useResolvedPath doesn't include any parts of the current page pathname in the result, resulting in just e.g. /data-source, and thus useMatch never returns a match.

Not sure exactly why this happens, since we get a full resolved path when calling useMatchSubpath in at least RegularFeatureInstance.tsx, but it's probably related to where we render the components in the component tree, and Sidebar is rendered outside the React Router Outlet component.

I found out these differences with some console.logs in useMatchSubpath.

The fix is to include the full path when calling useMatchSubpath in Sidebar, so that it fully matches the current location used by useMatch.

Our `useMatchSubpath` hook uses these two react-router-dom hooks: 1. useResolvedPath 2. useMatch After some investigation, I found that useMatch doesn't work with relative or partial paths: remix-run/react-router#8684 (comment). Furthermore, in our Sidebar useResolvedPath doesn't include any parts of the current page pathname in the result, resulting in just e.g. /data-source, and thus useMatch doesn't return a match. Not sure exactly why this happens, since we get a full resolved path when calling useMatchSubpath in at least RegularFeatureInstance.tsx, but it's probably related to where we render the components in the component tree, and Sidebar is rendered outside the React Router Outlet component. I found out these differences with some console.logs in useMatchSubpath. The fix is to include the full path when calling useMatchSubpath in Sidebar, so that it fully matches the current location used by useMatch. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
peruukki requested a review from a team as a code owner January 26, 2025 12:50
franciscojavierarceo enabled auto-merge (squash) January 26, 2025 13:55
franciscojavierarceo merged commit 8ac6a85 into feast-dev:master Jan 26, 2025
franciscojavierarceo pushed a commit that referenced this pull request Feb 4, 2025
# [0.44.0](v0.43.0...v0.44.0) (2025-02-04) ### Bug Fixes * Adding periodic check to fix the sporadic failures of the operator e2e tests. ([#4952](#4952)) ([1d086be](1d086be)) * Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee)) * Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f)) * Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962) * Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85)) * Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d)) * Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939)) * Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9)) * Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52)) * Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703)) * Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3)) * Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102)) * Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68)) * Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55)) ### Features * Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8)) * Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852)) * Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d)) * Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3)) * Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc)) * Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13)) * Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364)) * Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c)) * Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.