← 返回首页
feat: Feast Operator support log level configuration for services by redhatHameed · Pull Request #4808 · feast-dev/feast · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

feat: Feast Operator support log level configuration for services#4808

Merged
tchughesiv merged 7 commits into
feast-dev:masterfrom
redhatHameed:log-level
Dec 5, 2024
Merged

feat: Feast Operator support log level configuration for services#4808
tchughesiv merged 7 commits into
feast-dev:masterfrom
redhatHameed:log-level

Conversation

Copy link
Copy Markdown
Contributor

redhatHameed commented Dec 3, 2024
edited
Loading

What this PR does / why we need it:

added log level configuration in FeatureStore CR, followed the requirements from https://github.com/feast-dev/feast/blob/master/sdk/python/feast/cli.py#L85, only allow values "debug", "info", "warning", "error", "critical".

spec: feastProject: test services: offlineStore: logLevel: debug onlineStore: logLevel: debug registry: local: logLevel: debug

optional, would add the following at service startup -

--log-level DEBUG

The --log-level parameter should be included in the Feast service deployment command only if it is explicitly configured in the (CR) by the user.
If logLevel is not specified in the CR, the deployment command should not include the --log-level parameter.

Successfully verified PR changes by deploying operator. as shown

Which issue(s) this PR fixes:

Fixes #4810

Misc

redhatHameed changed the title feat : Feast Operator support log level configuration for services feat: Feast Operator support log level configuration for services Dec 4, 2024
redhatHameed force-pushed the log-level branch 3 times, most recently from 11424d8 to 58f024b Compare December 4, 2024 03:32
redhatHameed marked this pull request as ready for review December 4, 2024 03:45
redhatHameed requested a review from a team as a code owner December 4, 2024 03:45
Comment thread infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved
Copy link
Copy Markdown
Contributor

tchughesiv left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

please create a corresponding gh issue to track this change and be sure you have a successful make test locally before commiting

Comment thread infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved
Copy link
Copy Markdown
Contributor

tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

this needs some unit tests

Comment thread infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved
Copy link
Copy Markdown
Contributor Author

please create a corresponding gh issue to track this change and be sure you have a successful make test locally before commiting

done, and PR checking now successful.

Comment thread infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved
Copy link
Copy Markdown
Contributor Author

this needs some unit tests

Thanks @tchughesiv added, Please have a look.

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

this will break at runtime as-is ...

% feast serve -h 0.0.0.0 --log-level DEBUG Usage: feast serve [OPTIONS] Try 'feast serve --help' for help. Error: No such option: --log-level

needs to look like this -

% feast --log-level DEBUG serve -h 0.0.0.0

Comment thread infra/feast-operator/config/samples/v1alpha1_featurestore_services_loglevel.yaml Outdated Show resolved Hide resolved
Comment thread infra/feast-operator/api/v1alpha1/featurestore_types.go Outdated Show resolved Hide resolved
Comment thread infra/feast-operator/config/samples/v1alpha1_featurestore_services_loglevel.yaml Outdated Show resolved Hide resolved
Comment thread infra/feast-operator/internal/controller/featurestore_controller_loglevel_test.go Outdated Show resolved Hide resolved
redhatHameed and others added 6 commits December 5, 2024 17:03
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com> Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com> Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
Copy link
Copy Markdown
Contributor

@redhatHameed looks like might need to rebase on master

Copy link
Copy Markdown
Contributor

tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

lgtm

…validate it Signed-off-by: Abdul Hameed <ahameed@redhat.com>
tchughesiv enabled auto-merge (squash) December 5, 2024 22:15
tchughesiv merged commit 19424bc into feast-dev:master Dec 5, 2024
dharmisha pushed a commit to nishantgaurav-dev/feast that referenced this pull request Jan 15, 2025
…ast-dev#4808) * fix: Feast Operator updated the kustomize version to v5.5.0 Signed-off-by: Abdul Hameed <ahameed@redhat.com> * feat : Feast Operator support log level configuration for services Signed-off-by: Abdul Hameed <ahameed@redhat.com> * Update infra/feast-operator/internal/controller/services/services.go Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com> Signed-off-by: Abdul Hameed <ahameed@redhat.com> * Update infra/feast-operator/internal/controller/services/services.go Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com> Signed-off-by: Abdul Hameed <ahameed@redhat.com> * added unit test for loglevel Signed-off-by: Abdul Hameed <ahameed@redhat.com> * fix the loglevel command Signed-off-by: Abdul Hameed <ahameed@redhat.com> * moved the logLevel under LocalRegistryConfig and updated testcase to validate it Signed-off-by: Abdul Hameed <ahameed@redhat.com> --------- Signed-off-by: Abdul Hameed <ahameed@redhat.com> Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com>
franciscojavierarceo pushed a commit that referenced this pull request Jan 20, 2025
# [0.43.0](v0.42.0...v0.43.0) (2025-01-20) ### Bug Fixes * Add k8s module to feature-server image ([#4839](#4839)) ([f565565](f565565)) * Adding input to workflow ([e3e8c97](e3e8c97)) * Change image push to use --all-tags option ([#4926](#4926)) ([02458fd](02458fd)) * Fix integration build/push for images ([#4923](#4923)) ([695e49b](695e49b)) * Fix integration operator push ([#4924](#4924)) ([13c7267](13c7267)) * Fix release.yml ([#4845](#4845)) ([b4768a8](b4768a8)) * Fixing some of the warnings with the github actions ([#4763](#4763)) ([1119439](1119439)) * Improve status.applied updates & add offline pvc unit test ([#4871](#4871)) ([3f49517](3f49517)) * Made fixes to Go Operator DB persistence ([#4830](#4830)) ([cdc0753](cdc0753)) * Make transformation_service_endpoint configuration optional ([#4880](#4880)) ([c62377b](c62377b)) * Move pre-release image builds to quay.io, retire gcr.io pushes ([#4922](#4922)) ([40b975b](40b975b)) * Performance regression in /get-online-features ([#4892](#4892)) ([0db56a2](0db56a2)) * Refactor Operator to deploy all feast services to the same Deployment/Pod ([#4863](#4863)) ([88854dd](88854dd)) * Remove unnecessary google cloud steps & upgrade docker action versions ([#4925](#4925)) ([32aaf9a](32aaf9a)) * Remove verifyClient TLS offlineStore option from the Operator ([#4847](#4847)) ([79fa247](79fa247)) * Resolving syntax error while querying a feature view with column name starting with a number and BigQuery as data source ([#4908](#4908)) ([d3495a0](d3495a0)) * Updated python-helm-demo example to use MinIO instead of GS ([#4691](#4691)) ([31afd99](31afd99)) ### Features * Add date field support to spark ([#4913](#4913)) ([a8aeb79](a8aeb79)) * Add date support when converting from python to feast types ([#4918](#4918)) ([bd9f071](bd9f071)) * Add duckdb extra to multicloud release image ([#4862](#4862)) ([b539eba](b539eba)) * Add milvus package to release image & option to Operator ([#4870](#4870)) ([ef724b6](ef724b6)) * Add Milvus Vector Database Implementation ([#4751](#4751)) ([22c7b58](22c7b58)) * Add online/offline replica support ([#4812](#4812)) ([b97da6c](b97da6c)) * Added pvc accessModes support ([#4851](#4851)) ([a73514c](a73514c)) * Adding EnvFrom support for the OptionalConfigs type to the Go Operator ([#4909](#4909)) ([e01e510](e01e510)) * Adding Feature Server to components docs ([#4868](#4868)) ([f95e54b](f95e54b)) * Adding features field to retrieve_online_features to return mor… ([#4869](#4869)) ([7df287e](7df287e)) * Adding packages for Milvus Online Store ([#4854](#4854)) ([49171bd](49171bd)) * Adding vector_search parameter to fields ([#4855](#4855)) ([739eaa7](739eaa7)) * Feast Operator support log level configuration for services ([#4808](#4808)) ([19424bc](19424bc)) * Go Operator - Parsing the output to go structs ([#4832](#4832)) ([732865f](732865f)) * Implement `date_partition_column` for `SparkSource` ([#4844](#4844)) ([c5ffa03](c5ffa03)) * Loading the CA trusted store certificate into Feast to verify the public certificate. ([#4852](#4852)) ([132ce2a](132ce2a)) * Operator E2E test to validate FeatureStore custom resource using remote registry ([#4822](#4822)) ([d558ef7](d558ef7)) * Operator improvements ([#4928](#4928)) ([7a1f4dd](7a1f4dd)) * Removing the tls_verify_client flag from feast cli for offline server. ([#4842](#4842)) ([8320e23](8320e23)) * Separating the RBAC and Remote related integration tests. ([#4905](#4905)) ([76e1e21](76e1e21)) * Snyk vulnerability issues fix. ([#4867](#4867)) ([dbc9207](dbc9207)), closes [#6](#6) [#3](#3) [#4](#4) * Use ASOF JOIN in Snowflake offline store query ([#4850](#4850)) ([8f591a2](8f591a2)) ### Reverts * Revert "chore: Add Milvus to pr_integration_tests.yml" ([#4900](#4900)) ([07958f7](07958f7)), closes [#4891](#4891)
tmihalac pushed a commit to opendatahub-io/feast that referenced this pull request Jan 21, 2025
# [0.43.0](feast-dev/feast@v0.42.0...v0.43.0) (2025-01-20) ### Bug Fixes * Add k8s module to feature-server image ([feast-dev#4839](feast-dev#4839)) ([f565565](feast-dev@f565565)) * Adding input to workflow ([e3e8c97](feast-dev@e3e8c97)) * Change image push to use --all-tags option ([feast-dev#4926](feast-dev#4926)) ([02458fd](feast-dev@02458fd)) * Fix integration build/push for images ([feast-dev#4923](feast-dev#4923)) ([695e49b](feast-dev@695e49b)) * Fix integration operator push ([feast-dev#4924](feast-dev#4924)) ([13c7267](feast-dev@13c7267)) * Fix release.yml ([feast-dev#4845](feast-dev#4845)) ([b4768a8](feast-dev@b4768a8)) * Fixing some of the warnings with the github actions ([feast-dev#4763](feast-dev#4763)) ([1119439](feast-dev@1119439)) * Improve status.applied updates & add offline pvc unit test ([feast-dev#4871](feast-dev#4871)) ([3f49517](feast-dev@3f49517)) * Made fixes to Go Operator DB persistence ([feast-dev#4830](feast-dev#4830)) ([cdc0753](feast-dev@cdc0753)) * Make transformation_service_endpoint configuration optional ([feast-dev#4880](feast-dev#4880)) ([c62377b](feast-dev@c62377b)) * Move pre-release image builds to quay.io, retire gcr.io pushes ([feast-dev#4922](feast-dev#4922)) ([40b975b](feast-dev@40b975b)) * Performance regression in /get-online-features ([feast-dev#4892](feast-dev#4892)) ([0db56a2](feast-dev@0db56a2)) * Refactor Operator to deploy all feast services to the same Deployment/Pod ([feast-dev#4863](feast-dev#4863)) ([88854dd](feast-dev@88854dd)) * Remove unnecessary google cloud steps & upgrade docker action versions ([feast-dev#4925](feast-dev#4925)) ([32aaf9a](feast-dev@32aaf9a)) * Remove verifyClient TLS offlineStore option from the Operator ([feast-dev#4847](feast-dev#4847)) ([79fa247](feast-dev@79fa247)) * Resolving syntax error while querying a feature view with column name starting with a number and BigQuery as data source ([feast-dev#4908](feast-dev#4908)) ([d3495a0](feast-dev@d3495a0)) * Updated python-helm-demo example to use MinIO instead of GS ([feast-dev#4691](feast-dev#4691)) ([31afd99](feast-dev@31afd99)) ### Features * Add date field support to spark ([feast-dev#4913](feast-dev#4913)) ([a8aeb79](feast-dev@a8aeb79)) * Add date support when converting from python to feast types ([feast-dev#4918](feast-dev#4918)) ([bd9f071](feast-dev@bd9f071)) * Add duckdb extra to multicloud release image ([feast-dev#4862](feast-dev#4862)) ([b539eba](feast-dev@b539eba)) * Add milvus package to release image & option to Operator ([feast-dev#4870](feast-dev#4870)) ([ef724b6](feast-dev@ef724b6)) * Add Milvus Vector Database Implementation ([feast-dev#4751](feast-dev#4751)) ([22c7b58](feast-dev@22c7b58)) * Add online/offline replica support ([feast-dev#4812](feast-dev#4812)) ([b97da6c](feast-dev@b97da6c)) * Added pvc accessModes support ([feast-dev#4851](feast-dev#4851)) ([a73514c](feast-dev@a73514c)) * Adding EnvFrom support for the OptionalConfigs type to the Go Operator ([feast-dev#4909](feast-dev#4909)) ([e01e510](feast-dev@e01e510)) * Adding Feature Server to components docs ([feast-dev#4868](feast-dev#4868)) ([f95e54b](feast-dev@f95e54b)) * Adding features field to retrieve_online_features to return mor… ([feast-dev#4869](feast-dev#4869)) ([7df287e](feast-dev@7df287e)) * Adding packages for Milvus Online Store ([feast-dev#4854](feast-dev#4854)) ([49171bd](feast-dev@49171bd)) * Adding vector_search parameter to fields ([feast-dev#4855](feast-dev#4855)) ([739eaa7](feast-dev@739eaa7)) * Feast Operator support log level configuration for services ([feast-dev#4808](feast-dev#4808)) ([19424bc](feast-dev@19424bc)) * Go Operator - Parsing the output to go structs ([feast-dev#4832](feast-dev#4832)) ([732865f](feast-dev@732865f)) * Implement `date_partition_column` for `SparkSource` ([feast-dev#4844](feast-dev#4844)) ([c5ffa03](feast-dev@c5ffa03)) * Loading the CA trusted store certificate into Feast to verify the public certificate. ([feast-dev#4852](feast-dev#4852)) ([132ce2a](feast-dev@132ce2a)) * Operator E2E test to validate FeatureStore custom resource using remote registry ([feast-dev#4822](feast-dev#4822)) ([d558ef7](feast-dev@d558ef7)) * Operator improvements ([feast-dev#4928](feast-dev#4928)) ([7a1f4dd](feast-dev@7a1f4dd)) * Removing the tls_verify_client flag from feast cli for offline server. ([feast-dev#4842](feast-dev#4842)) ([8320e23](feast-dev@8320e23)) * Separating the RBAC and Remote related integration tests. ([feast-dev#4905](feast-dev#4905)) ([76e1e21](feast-dev@76e1e21)) * Snyk vulnerability issues fix. ([feast-dev#4867](feast-dev#4867)) ([dbc9207](feast-dev@dbc9207)), closes [#6](feast-dev#6) [#3](feast-dev#3) [#4](feast-dev#4) * Use ASOF JOIN in Snowflake offline store query ([feast-dev#4850](feast-dev#4850)) ([8f591a2](feast-dev@8f591a2)) ### Reverts * Revert "chore: Add Milvus to pr_integration_tests.yml" ([feast-dev#4900](feast-dev#4900)) ([07958f7](feast-dev@07958f7)), closes [feast-dev#4891](feast-dev#4891)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feast Operator: Support Log Level Configuration in FeatureStore CR for Feature Services

4 participants

Footer

© 2026 GitHub, Inc.