← 返回首页
fix: FeastExtrasDependencyImportError when using SparkOfflineStore without S3 by aloysius-lim · Pull Request #4594 · feast-dev/feast · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

fix: FeastExtrasDependencyImportError when using SparkOfflineStore without S3 #4594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 2 commits into from
Oct 2, 2024
Conversation 1 Commits 2 Checks 0 Files changed
Merged

fix: FeastExtrasDependencyImportError when using SparkOfflineStore without S3 #4594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4437cd2
Import aws_utils only if using s3.
aloysius-lim Oct 2, 2024
0342a6e
Lint.
aloysius-lim Oct 2, 2024
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected Viewed files
Conversations
Failed to load comments. Retry
Loading
Jump to
Jump to file
Failed to load files. Retry
Loading
Diff view
Unified
Split
Hide whitespace
Apply and reload
Show whitespace
Diff view
Unified
Split
Hide whitespace
Apply and reload
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.py
Show comments
View file Edit file Delete file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
RetrievalMetadata,
)
from feast.infra.registry.base_registry import BaseRegistry
from feast.infra.utils import aws_utils
from feast.repo_config import FeastConfigBaseModel, RepoConfig
from feast.saved_dataset import SavedDatasetStorage
from feast.type_map import spark_schema_to_np_dtypes
Expand Down Expand Up @@ -399,6 +398,8 @@ def to_remote_storage(self) -> List[str]:

return _list_files_in_folder(output_uri)
elif self._config.offline_store.staging_location.startswith("s3://"):
from feast.infra.utils import aws_utils

spark_compatible_s3_staging_location = (
self._config.offline_store.staging_location.replace(
"s3://", "s3a://"
Expand Down
Toggle all file notes Toggle all file annotations

Footer

© 2026 GitHub, Inc.