← 返回首页
chore: Migrate from setup.py to pyproject.toml by tokoko · Pull Request #4478 · feast-dev/feast · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

chore: Migrate from setup.py to pyproject.toml#4478

Closed
tokoko wants to merge 6 commits into
feast-dev:masterfrom
tokoko:pyproject-toml
Closed

chore: Migrate from setup.py to pyproject.toml#4478
tokoko wants to merge 6 commits into
feast-dev:masterfrom
tokoko:pyproject-toml

Conversation

tokoko commented Sep 3, 2024

Copy link
Copy Markdown
Collaborator
  • Migrates most of setup.py configuration to pyproject.toml in line with PEP 518
  • Some misc changes to suppress linter issues in tests

chore: migrate to pyproject.toml …
1eccad3
Signed-off-by: tokoko <togurgenidze@gmail.com>
franciscojavierarceo reviewed Sep 3, 2024
View reviewed changes
Comment thread environment-setup.md Show resolved Hide resolved
fix: remove env setup reference from development guide …
cea6be8
Signed-off-by: tokoko <togurgenidze@gmail.com>
franciscojavierarceo reviewed Sep 3, 2024
View reviewed changes
Comment thread setup.py Show resolved Hide resolved

franciscojavierarceo commented Sep 3, 2024

Copy link
Copy Markdown
Member

It'd probably be ideal to have #4344 done before merging this, yeah?

HaoXuAI reviewed Sep 3, 2024
View reviewed changes
Comment thread pyproject.toml Show resolved Hide resolved
add cli import test with pixi …
95c1f61
Signed-off-by: tokoko <togurgenidze@gmail.com>
fix pixi install in gh actions …
50d370b
Signed-off-by: tokoko <togurgenidze@gmail.com>
fix pixi install in gh actions …
c334e44
Signed-off-by: tokoko <togurgenidze@gmail.com>
remove duplicate virtualenv dependency …
a46f9c3
Signed-off-by: tokoko <togurgenidze@gmail.com>

redhatHameed commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

@tokoko clarification,I have one task on my to-do list related to this conversation-> #4380 (comment) do you think it's still valid after this PR change. Thanks

tokoko commented Sep 13, 2024

Copy link
Copy Markdown
Collaborator Author

@redhatHameed yup, that's still valid. this PR only changes where requirements are defined, nothing else.

tokoko mentioned this pull request Sep 18, 2024
Closed

stale Bot commented Apr 26, 2025

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale Bot added the wontfix This will not be worked on label Apr 26, 2025
stale Bot closed this May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

franciscojavierarceo franciscojavierarceo left review comments
HaoXuAI HaoXuAI left review comments

Assignees

No one assigned

Labels

ok-to-test wontfix This will not be worked on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Footer

© 2026 GitHub, Inc.