feat: Feast Security Model (aka RBAC) by dmartinol · Pull Request #4380 · feast-dev/feast · GitHub

feat: Feast Security Model (aka RBAC)#4380

Merged

franciscojavierarceo merged 170 commits into

feast-dev:masterfrom

RHEcosystemAppEng:feast-rbac

Aug 21, 2024

Commits on Aug 19, 2024

initial commit

dmartinol
authored and
redhatHameed
committed
fixed linting issues (but 1)

dmartinol
authored and
redhatHameed
committed
deleted AuthzedResource and moved types to the Permission class

dmartinol
authored and
redhatHameed
committed
using pytest.mark.parametrize tests

dmartinol
authored and
redhatHameed
committed
moved decorator to decorator module

dmartinol
authored and
redhatHameed
committed
parametrized decision tests

dmartinol
authored and
redhatHameed
committed
Added matcher and action modules. Added global assert_permissions function

dmartinol
authored and
redhatHameed
committed
fixed linting error

dmartinol
authored and
redhatHameed
committed
Managing with_subclasses flag and overriding it in case it's an abstract class like DataSource

dmartinol
authored and
redhatHameed
committed
Permission includes a single Policy

dmartinol
authored and
redhatHameed
committed
completed docstrings for permissions package

dmartinol
authored and
redhatHameed
committed
fixed inter issues

dmartinol
authored and
redhatHameed
committed
Changed roles matching rule from "all" to "any"

dmartinol
authored and
redhatHameed
committed
Introducing permission framework and authorization manager in user guide (to be continued after the code is consolidated)

dmartinol
authored and
redhatHameed
committed
removed test code

dmartinol
authored and
redhatHameed
committed
hiding sensitive data (false positive, anyway)

dmartinol
authored and
redhatHameed
committed
Added filter_only flag to assert_permissions and returning a list of filtered resources instead of PermissionError

dmartinol
authored and
redhatHameed
committed
added the option to return the single resource, or None

dmartinol
authored and
redhatHameed
committed
separate validating functions: assert_permission and filtered_resources

dmartinol
authored and
redhatHameed
committed
Store and Manage permissions in the Registry

tmihalac
authored and
redhatHameed
committed
Applied review comments

tmihalac
authored and
redhatHameed
committed
Store and Manage permissions in the Registry

tmihalac
authored and
redhatHameed
committed
Store and Manage permissions in the Registry

tmihalac
authored and
redhatHameed
committed
Store and Manage permissions in the Registry

tmihalac
authored and
redhatHameed
committed
Store and Manage permissions in the Registry

tmihalac
authored and
redhatHameed
committed
Store and Manage permissions in the Registry

tmihalac
authored and
redhatHameed
committed
Store and Manage permissions in the Registry

tmihalac
authored and
redhatHameed
committed
Store and Manage permissions in the Registry

tmihalac
authored and
redhatHameed
committed
replaced aggregated actions with aliases for QUERY and WRITE and ALL

dmartinol
authored and
redhatHameed
committed
Updated user guide

dmartinol
authored and
redhatHameed
committed
Updated enum in proto

dmartinol
authored and
redhatHameed
committed
Store and Manage permissions in the Registry

tmihalac
authored and
redhatHameed
committed
Store and Manage permissions in the Registry

tmihalac
authored and
redhatHameed
committed
Added permission assert check for registry server, offline server, online server functions
redhatHameed
committed
Fix linter after rebase
redhatHameed
committed
CLI command "feast permissions list"

tmihalac
authored and
redhatHameed
committed
CLI command "feast permissions list"

tmihalac
authored and
redhatHameed
committed
CLI command "feast permissions list"

tmihalac
authored and
redhatHameed
committed
added the documents reference for permissions for online, offline, registry server endpoints.
redhatHameed
committed
Incorporating code review comments to parse the auth block from the f… (#36)

lokeshrangineni
authored and
redhatHameed
committed
definition and integration of auth manager in feast offline and online servers

dmartinol
authored and
redhatHameed
committed
typo

dmartinol
authored and
redhatHameed
committed
duplicated if

dmartinol
authored and
redhatHameed
committed
renamed functions with long name

dmartinol
authored and
redhatHameed
committed
using User class instead of RoleManager (completely removed)

dmartinol
authored and
redhatHameed
committed
Feed SecurityManager with Registry instance to fetch the actual permissions

dmartinol
authored and
redhatHameed
committed
fixed linter

dmartinol
authored and
redhatHameed
committed
review comments

dmartinol
authored and
redhatHameed
committed
fixed broken IT

dmartinol
authored and
redhatHameed
committed
Adding registry server (UT to be completed)

dmartinol
authored and
redhatHameed
committed
fix linter

dmartinol
authored and
redhatHameed
committed
passing auth manager type from config

dmartinol
authored and
redhatHameed
committed
used auth config to set auth manager type
redhatHameed
committed
inject the user details
redhatHameed
committed
created decorator function and applied to arrow function for injecting the user detail:wq
redhatHameed
committed
code review fixes including the unit test and integration test as suggested
redhatHameed
committed
Implementation of oidc client authentication. (#40)

lokeshrangineni
authored and
redhatHameed
committed
Client module-grpc

tmihalac
authored and
redhatHameed
committed
Client module-grpc

tmihalac
authored and
redhatHameed
committed
Client module-grpc

tmihalac
authored and
redhatHameed
committed
Client module-grpc

tmihalac
authored and
redhatHameed
committed
Client module-grpc

tmihalac
authored and
redhatHameed
committed
Client module-grpc

tmihalac
authored and
redhatHameed
committed
Client module-grpc

tmihalac
authored and
redhatHameed
committed
Client module-grpc

tmihalac
authored and
redhatHameed
committed
added auth configuration for arrow flight client
redhatHameed
committed
Client module-grpc

tmihalac
authored and
redhatHameed
committed
fix linter

dmartinol
authored and
redhatHameed
committed
Propagating auth config to token parser in server init

dmartinol
authored and
redhatHameed
committed
adding headers and client_secret to token request

dmartinol
authored and
redhatHameed
committed
working E2E test of authenticated registy server

dmartinol
authored and
redhatHameed
committed
renamed test

dmartinol
authored and
redhatHameed
committed
fixed broken test

dmartinol
authored and
redhatHameed
committed
fix rebase issues

dmartinol
authored and
redhatHameed
committed
fix rebase issues

dmartinol
authored and
redhatHameed
committed
Adding the auth client documentations and unit testing for auth client code.

lokeshrangineni
authored and
redhatHameed
committed
Adding the auth client documentations and unit testing for auth client code.

lokeshrangineni
authored and
redhatHameed
committed
Incorporating code review comments.

lokeshrangineni
authored and
redhatHameed
committed
Incorporating code review comments.

lokeshrangineni
authored and
redhatHameed
committed
Introducing permission framework and authorization manager in user guide (to be continued after the code is consolidated)

dmartinol
authored and
redhatHameed
committed
CLI command "feast permissions list"

tmihalac
authored and
redhatHameed
committed
Client module-grpc

tmihalac
authored and
redhatHameed
committed
Fix auth tests with permissions

tmihalac
authored and
redhatHameed
committed
Fix auth tests with permissions

tmihalac
authored and
redhatHameed
committed
Fix auth tests with permissions

tmihalac
authored and
redhatHameed
committed
Fix auth tests with permissions

tmihalac
authored and
redhatHameed
committed
Moved the common fixtures to the root conftest.py or auth_permissions_util.py (#54)

lokeshrangineni
authored and
redhatHameed
committed
added check and list-roles subcommands

dmartinol
authored and
redhatHameed
committed
typo

dmartinol
authored and
redhatHameed
committed
added comment in cli_utils to remind the original function from which this logic was derived

dmartinol
authored and
redhatHameed
committed
1) Updating the existing integration test with auth permissions configurations.

lokeshrangineni
authored and
redhatHameed
committed
Moved the common fixtures to the root conftest.py or auth_permissions_util.py

lokeshrangineni
authored and
redhatHameed
committed
Adding missed dependency and regenerated the requirements files.

lokeshrangineni
authored and
redhatHameed
committed
1) Updating the existing integration test with auth permissions configurations.

lokeshrangineni
authored and
redhatHameed
committed
1) Fixing an issue with the way getting markers after changing the fixture scope to module. Now looking up the markers coming from the entire module run.

lokeshrangineni
authored and
redhatHameed
committed
Fixed bug in GetPermission API

dmartinol
authored and
redhatHameed
committed
Permission CRUD test

dmartinol
authored and
redhatHameed
committed
Added feast-rbac example
redhatHameed
committed
Added support to read the token from enviroment variable to run from local
redhatHameed
committed
Fix the header for arrow fligth
redhatHameed
committed
fix the header issue
redhatHameed
committed
added permissions apply file
redhatHameed
committed
set the user in the grpc server
redhatHameed
committed
added roles and updated permission with all roles
redhatHameed
committed
updated chart to include the service account
redhatHameed
committed
created client example with roles and updated installation/cleanup script
redhatHameed
committed
rebased with master
redhatHameed
committed
Moved the common fixtures to the root conftest.py or auth_permissions_util.py (#54)

lokeshrangineni
authored and
redhatHameed
committed
Fixed DecisionStrategy not persisted

tmihalac
authored and
redhatHameed
committed
Fixed DecisionStrategy not persisted

tmihalac
authored and
redhatHameed
committed
Fixed DecisionStrategy not persisted

tmihalac
authored and
redhatHameed
committed
Revert "Fix decision strategy not saved"

dmartinol
authored and
redhatHameed
committed
Dropped global decision strategy

dmartinol
authored and
redhatHameed
committed
updated rbac demo example
redhatHameed
committed
Adding permissions directly instead of from the common place for the online read integration tests.

lokeshrangineni
authored and
redhatHameed
committed
Initial Draft version to the tests with remote offline server with OIDC authentication permissions. Happy path only.

lokeshrangineni
authored and
redhatHameed
committed
Abstracting the specific code for Offline Permissions by creating new class for PermissionsEnvironment.

lokeshrangineni
authored and
redhatHameed
committed
Formatting the python files using make format-python.

lokeshrangineni
authored and
redhatHameed
committed
Separated the permissions for online, offline and registry servers. moved the fixtures scope accordingly as we can't reuse the permissions for all the test cases.

lokeshrangineni
authored and
redhatHameed
committed
Separated the permissions for online, offline and registry servers. moved the fixtures scope accordingly as we can't reuse the permissions for all the test cases.

lokeshrangineni
authored and
redhatHameed
committed
Created the grpc client auth header interceptor and removed the manual injection of the header.

lokeshrangineni
authored and
redhatHameed
committed
Created the grpc client auth header interceptor and removed the manual injection of the header.

lokeshrangineni
authored and
redhatHameed
committed
fix: java to proto failing

tmihalac
authored and
redhatHameed
committed
CLI command "feast permissions list"

tmihalac
authored and
redhatHameed
committed
Moved the common fixtures to the root conftest.py or auth_permissions_util.py (#54)

lokeshrangineni
authored and
redhatHameed
committed
fix: java to proto failing

tmihalac
authored and
redhatHameed
committed
Adding the extra writer permission to fix the integration test issue with offline server.

lokeshrangineni
authored and
redhatHameed
committed
Try to fix java integration test - ModuleNotFoundError: No module named 'feast.permissions.server'

tmihalac
authored and
redhatHameed
committed
fix java integration test - ModuleNotFoundError: No module named 'jwt'

tmihalac
authored and
redhatHameed
committed
fix java integration test - ModuleNotFoundError: No module named 'kubernetes'

tmihalac
authored and
redhatHameed
committed
Adding missing permissions for offline store test cases - classes FileSource, FeatureService classes. (#64)

lokeshrangineni
authored and
redhatHameed
committed
Updating the offline integration test permissions.

lokeshrangineni
authored and
redhatHameed
committed
updated test.py file for rbac-example
redhatHameed
committed
fix the DeleteFeatureView function to handle stream feature view type
redhatHameed
committed
Updating permissions of the integration test cases to address code review comments and also check if the online_read integration test fixes.

lokeshrangineni
authored and
redhatHameed
committed
Incorporating the code review comments from Francisco on upstream PR.

lokeshrangineni
authored and
redhatHameed
committed
Update docs/getting-started/concepts/permission.md

2 peopleauthored and
redhatHameed
committed
Update docs/getting-started/concepts/permission.md

2 peopleauthored and
redhatHameed
committed
Update docs/getting-started/concepts/permission.md

2 peopleauthored and
redhatHameed
committed
Small fixes (#71)

dmartinol
authored and
redhatHameed
committed
commented/removed oidc tests to verify integration test
redhatHameed
committed
Enabling the keycloak related integration tests and also initializing the keycloak only once in the entire run.

lokeshrangineni
authored and
redhatHameed
committed
Making number of workers back to 8 and enabled the test_remote_online_store_read

lokeshrangineni
authored and
redhatHameed
committed
Making number of workers to 4.

lokeshrangineni
authored and
redhatHameed
committed
Incorporating the code review comments from Tornike to use @pytest.mark.xdist_group(name="keycloak").

lokeshrangineni
authored and
redhatHameed
committed
Reverting number of workers from 8 to 4.

lokeshrangineni
authored and
redhatHameed
committed
Reverting number of workers from 8 to 4. Reverting the marker @pytest.mark.xdist_group(name="keycloak")

lokeshrangineni
authored and
redhatHameed
committed
Reverting number of workers from 8 to 4 for make target test-python-integration-local

lokeshrangineni
authored and
redhatHameed
committed
Added the arrow flight interceptor to inject the auth header. (#68)

lokeshrangineni
authored and
redhatHameed
committed
removed with_subclasses option (it's the default and unique behavior)

dmartinol
authored and
redhatHameed
committed
a full, minimal, reproducible example of the RBAC feature

dmartinol
authored and
redhatHameed
committed
Add missing required_tags to permission object and cli info

tmihalac
authored and
redhatHameed
committed
Fixed the registry apply function assertation
redhatHameed
committed
removed the examples
redhatHameed
committed
Integrated comment

dmartinol
authored and
redhatHameed
committed
removed the firebase depdency and fix the doc conflicts
redhatHameed
committed
Introducing permission framework and authorization manager in user guide (to be continued after the code is consolidated)

dmartinol
authored and
redhatHameed
committed
Permission resources miss the created_timestamp and last_updated_timestamp fields

tmihalac
authored and
redhatHameed
committed
remove error incase if user has no roles assinged incase unthorized user
redhatHameed
committed
renamed READ action to DESCRIBE

dmartinol
authored and
redhatHameed
committed
Specified authorization manager and authorization configuration

dmartinol
authored and
redhatHameed
committed
fix the linter and remove subclass from doc
redhatHameed
committed

Commits on Aug 20, 2024

Commits on Aug 21, 2024

fix the doc to replace query with read
redhatHameed
committed

Terms
Privacy
Security
Status
Community
Docs
Contact
Manage cookies
Do not share my personal information

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Feast Security Model (aka RBAC)#4380

feat: Feast Security Model (aka RBAC)#4380franciscojavierarceo merged 170 commits intofeast-dev:masterfeast-dev/feast:masterfrom RHEcosystemAppEng:feast-rbacRHEcosystemAppEng/feast:feast-rbacCopy head branch name to clipboard

Commits

Commits on Aug 19, 2024

feat: Feast Security Model (aka RBAC)#4380
franciscojavierarceo merged 170 commits into
feast-dev:masterfrom
RHEcosystemAppEng:feast-rbac