← 返回首页
Interactivity attempt 4 by clewis7 · Pull Request #93 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

Interactivity attempt 4#93

Merged
kushalkolar merged 13 commits into
masterfrom
interactivity-rebase
Dec 29, 2022
Merged

Interactivity attempt 4#93
kushalkolar merged 13 commits into
masterfrom
interactivity-rebase

Conversation

clewis7 commented Dec 28, 2022

Copy link
Copy Markdown
Member

git hates me, feeling is mutual

implements #39

hopefully the last interactivity branch before it can be merged

clewis7 commented Dec 28, 2022

Copy link
Copy Markdown
Member Author

okay, functionality is back to where it was before...can click on single contour and change color

should now be ready to finish interactivity

kushalkolar reviewed Dec 28, 2022
View reviewed changes
Comment thread fastplotlib/graphics/_base.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/_base.py Show resolved Hide resolved
Comment thread fastplotlib/graphics/line.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/line.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/line.py Outdated Show resolved Hide resolved
2 hidden conversations Load more…
Comment thread fastplotlib/graphics/linecollection.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/linecollection.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/linecollection.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/linecollection.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/linecollection.py Outdated Show resolved Hide resolved

clewis7 commented Dec 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

update: about to start working on line collection but made the changes you suggested to base and line graphics

line graphic is single graphic so it normally wouldn't have indices, but I made sure that it would work if slice, int, etc. is passed into set_feature just in the event that it would happen

reset_feature also works nicely when indices are included or not!!

kushalkolar reviewed Dec 29, 2022
View reviewed changes
Comment thread fastplotlib/graphics/line.py Outdated Show resolved Hide resolved
kushalkolar merged commit 011bab6 into master Dec 29, 2022
This was referenced Dec 30, 2022
Closed
Closed
Open
kushalkolar deleted the interactivity-rebase branch March 4, 2023 02:00
kushalkolar changed the title Interactivity rebase Interactivity attempt 4 Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kushalkolar kushalkolar left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.