← 返回首页
thinner lines for Linear and LinearRegion selectors, fully transparent thick outer lines as hitboxes by kushalkolar · Pull Request #904 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

thinner lines for Linear and LinearRegion selectors, fully transparent thick outer lines as hitboxes#904

Closed
kushalkolar wants to merge 10 commits into
mainfrom
better-selector-handles
Closed

thinner lines for Linear and LinearRegion selectors, fully transparent thick outer lines as hitboxes#904
kushalkolar wants to merge 10 commits into
mainfrom
better-selector-handles

Conversation

kushalkolar commented Sep 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

After the alpha refactor by @almarklein this is finally possible! I think this looks much better, the width of the outer transparent line is a kwarg hitbox_width

linear-2025-09-29_03.30.43.mp4 linear_region-2025-09-29_03.38.24.mp4

kushalkolar mentioned this pull request Sep 29, 2025
Open
almarklein reviewed Sep 29, 2025
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_linear.py Outdated Show resolved Hide resolved
almarklein reviewed Sep 29, 2025
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_base_selector.py Outdated Show resolved Hide resolved
almarklein reviewed Sep 29, 2025
View reviewed changes
Comment thread fastplotlib/graphics/selectors/_linear_region.py Show resolved Hide resolved

kushalkolar commented Sep 29, 2025

Copy link
Copy Markdown
Member Author

@almarklein do you think this is overall the right approach here after your alpha refactor?

kushalkolar marked this pull request as ready for review September 30, 2025 07:53
This was referenced Oct 1, 2025
Open
Merged
clewis7 previously approved these changes Oct 3, 2025
View reviewed changes

clewis7 commented Oct 3, 2025

Copy link
Copy Markdown
Member

docs are failing? and some of the tests should be passing no?

github-actions Bot commented Oct 6, 2025 •
edited
Loading

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/better-selector-handles

kushalkolar commented Oct 6, 2025

Copy link
Copy Markdown
Member Author

all non-release tests passing

kushalkolar mentioned this pull request Oct 9, 2025
Merged

kushalkolar commented Oct 10, 2025

Copy link
Copy Markdown
Member Author

Merge conflict in the lfs files O_O. I'm going to copy this over to a new PR before we discover novel ways to get git lfs smudge errors, @FlynnOConnell

kushalkolar mentioned this pull request Oct 11, 2025
Merged

kushalkolar commented Oct 11, 2025

Copy link
Copy Markdown
Member Author

superseeded by #914, I don't want to risk a git lfs error again with a merge conflict in an lfs pointer (how tf does that even happen?!? 😨 )

kushalkolar deleted the better-selector-handles branch October 14, 2025 04:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

almarklein almarklein left review comments
clewis7 clewis7 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Footer

© 2026 GitHub, Inc.