← 返回首页
remove `Graphic.share_property()` and `unshare_property()` by kushalkolar · Pull Request #842 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Resetting focus

remove Graphic.share_property() and unshare_property()#842

Merged
clewis7 merged 2 commits into
mainfrom
remove-share-property
Jun 2, 2025
Merged

remove Graphic.share_property() and unshare_property()#842
clewis7 merged 2 commits into
mainfrom
remove-share-property

Conversation

Copy link
Copy Markdown
Member

This really isn't required and brings in unnecessary complexity which is difficult to test. Sharing a buffer is easy, but toggling between the two can become messy. The docs already cover how to share a buffer:

# add a line line_graphic = figure[0, 0].add_line(data) # add a scatter, share the line graphic buffer! scatter_graphic = figure[0, 0].add_scatter(data=line_graphic.data, sizes=25, colors="r")

kushalkolar requested a review from clewis7 as a code owner May 28, 2025 19:48

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/remove-share-property

Copy link
Copy Markdown
Member Author

@clewis7 ready for review

Hide details View details clewis7 merged commit 15ab65f into main Jun 2, 2025
95 of 102 checks passed
clewis7 deleted the remove-share-property branch June 2, 2025 13:32
kushalkolar mentioned this pull request Sep 30, 2025
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Footer

© 2026 GitHub, Inc.