← 返回首页
docstring and docs cleanup, other misc small things by kushalkolar · Pull Request #828 · fastplotlib/fastplotlib · GitHub
Skip to content

Navigation Menu

Toggle navigation
Sign in
Appearance settings
Search or jump to...

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted
Cancel Submit feedback

Saved searches

Use saved searches to filter your results more quickly

Cancel Create saved search
Appearance settings
Resetting focus

docstring and docs cleanup, other misc small things#828

Merged
clewis7 merged 23 commits into
mainfrom
old-renames
May 20, 2025
Merged

docstring and docs cleanup, other misc small things#828
clewis7 merged 23 commits into
mainfrom
old-renames

Conversation

kushalkolar commented May 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Renamed lots of instances where gridplot was still lingering to Figure. There is no such thing as "grid plot" anymore so changed those descriptions to "grid layout".

Some other docstring cleanup, reword some things to be better. Some better error messages in Figure.__init__()

removed "padding" kwarg for add_linear_selector() methods since it's no longer required since we have inf lines 😄

also fixes #818

@clewis7 ready for review

kushalkolar requested a review from clewis7 as a code owner May 19, 2025 07:40
kushalkolar changed the title docstring and docs cleanup docstring and docs cleanup, other misc small things May 19, 2025
clewis7 requested changes May 19, 2025
View reviewed changes

clewis7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality Hide comment

Just some minor tweaks

Comment thread fastplotlib/graphics/image.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/image.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/line.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/text.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/text.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/text.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/text.py Outdated Show resolved Hide resolved
Comment thread fastplotlib/graphics/text.py Outdated Show resolved Hide resolved
kushalkolar and others added 2 commits May 19, 2025 17:03
Update fastplotlib/graphics/image.py …
48e324b
Co-authored-by: Caitlin Lewis <69729525+clewis7@users.noreply.github.com>
Apply suggestions from code review …
fc5c577
Co-authored-by: Caitlin Lewis <69729525+clewis7@users.noreply.github.com>

kushalkolar commented May 19, 2025

Copy link
Copy Markdown
Member Author

I'm going to add a test for figure name stuff

github-actions Bot commented May 20, 2025

Copy link
Copy Markdown

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/old-renames

kushalkolar commented May 20, 2025

Copy link
Copy Markdown
Member Author

@clewis7 ready for another look, better logic to check subplot_names size, tests for it, and updated add_ methods mixin

clewis7 merged commit 0de38a7 into main May 20, 2025
clewis7 deleted the old-renames branch May 20, 2025 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

clewis7 clewis7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImageWidget with 3+ subplots requires figure_shape

2 participants

Footer

© 2026 GitHub, Inc.